Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Klikkbar H2-overskrift for ankerlenke #1941

Merged
merged 16 commits into from
Jun 25, 2024
Merged

Klikkbar H2-overskrift for ankerlenke #1941

merged 16 commits into from
Jun 25, 2024

Conversation

terjeofnorway
Copy link
Contributor

@terjeofnorway terjeofnorway commented Jun 20, 2024 •
edited
Loading

Oppsummering av hva som er gjort

  • Setter inn a-tag der heading er h2 og introduserer en anchorOffset for å få til at headeren ikke scroller klint oppi toppen av siden.
  • Fjerner gammel mekanisme for å vise/skjule kopier lenke-knapp.
  • Fjerner "label" som ikke blir brukt i CopyLink
  • CopyLink beholdes fordi den brukes i oversiktssider.

Testing

Testes i dev

@terjeofnorway terjeofnorway marked this pull request as ready for review June 24, 2024 11:32
@terjeofnorway terjeofnorway requested a review from a team as a code owner June 24, 2024 11:32
@terjeofnorway terjeofnorway changed the title Kopier lenke-knapp Klikkbar H2-overskrift for ankerlenke Jun 24, 2024
bdahle
bdahle requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@bdahle bdahle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser ut til å funke fint, men ser at på "Pengestøtte når du får barn" og "Andre som kan hjelpe" scroller siden litt lenger ned enn på de andre lenkene

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@terjeofnorway terjeofnorway merged commit 268fce2 into master Jun 25, 2024
6 checks passed
@terjeofnorway terjeofnorway deleted the lenke-ikon branch June 25, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdahle bdahle bdahle requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terjeofnorway @bdahle