Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitt alternative audience #1962

Merged
merged 10 commits into from
Aug 30, 2024
Merged

Splitt alternative audience #1962

merged 10 commits into from
Aug 30, 2024

Conversation

bdahle
Copy link
Contributor

@bdahle bdahle commented Jul 10, 2024 •
edited
Loading

Oppsummering av hva som er gjort

  • Flytter "For målgruppe..." fra AlternativeAudience til tagline (over overskriften)
  • Trekker ut tagline til en egen komponent
  • Oppdaterer noen nynorsk-oversettelser som ser ut som de ble glemt i Fikse kategori tags #1923
  • (Sonarcloud duplication er i språkfil)

Testing

Har testet selv i dev

Skjermbilde hvis relevant

Screenshot 2024-08-26 at 12 18 34

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bdahle bdahle self-assigned this Jul 15, 2024
@bdahle bdahle linked an issue Aug 26, 2024 that may be closed by this pull request
Ny visning av målgruppe-tag ved overskrift i sidemaler #1980
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@bdahle bdahle marked this pull request as ready for review August 26, 2024 10:29
@bdahle bdahle requested a review from a team as a code owner August 26, 2024 10:29
@bdahle bdahle merged commit 2871212 into master Aug 30, 2024
5 of 6 checks passed
@bdahle bdahle deleted the splitt-alternative-audience branch August 30, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terjeofnorway terjeofnorway terjeofnorway approved these changes

Assignees

@bdahle bdahle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ny visning av målgruppe-tag ved overskrift i sidemaler
2 participants
@bdahle @terjeofnorway