Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amplitude: Rettet og refaktorert logging for alle Accordion-typer #2007

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

PerOlavM
Copy link
Contributor

@PerOlavM PerOlavM commented Sep 3, 2024

Oppsummering av hva som er gjort

Samme bruk av Amplitude for all kode som bruker Accordion, ReadMore, eller ExpansionCard (hvor vi ønsker logging):

  • Innfører isOpening som lokal variabel for toggle for større lesbarhet
  • Innfører komponent for lettere kobling tilbake til kode

Logging av Expandable også fra kontorsider

Testing

Har testet selv i dev

@PerOlavM PerOlavM requested a review from a team as a code owner September 3, 2024 08:48
Copy link

sonarqubecloud bot commented Sep 3, 2024

@PerOlavM PerOlavM merged commit a470acc into master Sep 3, 2024
6 checks passed
@PerOlavM PerOlavM deleted the amplitude-fix-accordions branch September 3, 2024 10:41
@PerOlavM PerOlavM linked an issue Sep 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amplitude: Justeringer for ALLE Accordions
2 participants