Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stories og types Themed Page Header #2029

Merged
merged 65 commits into from
Oct 9, 2024
Merged

Stories og types Themed Page Header #2029

merged 65 commits into from
Oct 9, 2024

Conversation

bdahle
Copy link
Contributor

@bdahle bdahle commented Oct 1, 2024

(Merget inn fire andre PRs for å ta en siste sjekk at ikke noe brekker i dev før merge til master)

Oppsummering av hva som er gjort

  • Strammer inn typedefinisjon for ThemedPageHeader
  • Lager stories til Storybook

Testing

Har testet selv lokalt

Skjermbilde hvis relevant

image

@bdahle bdahle marked this pull request as ready for review October 1, 2024 09:31
@bdahle bdahle requested a review from a team as a code owner October 1, 2024 09:31
@bdahle bdahle marked this pull request as draft October 1, 2024 12:34
@bdahle bdahle changed the title Header types and stories Story og types ThemedPageHeader Oct 2, 2024
@bdahle bdahle marked this pull request as ready for review October 2, 2024 11:27
@bdahle bdahle changed the title Story og types ThemedPageHeader Stories og types Themed Page Header Oct 2, 2024
Copy link

sonarqubecloud bot commented Oct 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@bdahle bdahle merged commit d5dc1b8 into master Oct 9, 2024
5 of 6 checks passed
@bdahle bdahle deleted the header-types-and-stories branch October 9, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants