Disable ux signals når samtykke ikke er gitt #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PerOlavM
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oppsummering av hva som er gjort
Widget for UX Signals laster inn et script (som også slettes når komponenten fjernes fra treet). Denne bør sjekke om samtykke er gitt. Det ble litt mer logikk for å få til dette, men oppsummert:
Testing
Testet i dev
Dette trenger jeg å få et ekstra blikk på
Jeg lurer på om koden ble litt kronglete med hensyn til lesbarhet, så ta en titt på om den er lesbar nok eller om jeg burde kikke på en bedre løsning.