Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Justert design for mellomsteg #2222

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c073171
frontend for tags
taniaholst Mar 17, 2025
c9e3482
Legger til ekstra steg i mellomsteg og forenkler typingen noe
terjeofnorway Mar 19, 2025
11c5042
Legger til funksjon for å finne forrige tittel
terjeofnorway Mar 19, 2025
54501a8
Merge branch 'main' into mellomsteg
taniaholst Mar 20, 2025
bc7fb7f
Merge pull request #2225 from navikt/flere-nivaer-i-mellomsteg
taniaholst Mar 20, 2025
a2f4191
ny komponent LanguageDisclaimer, flyttet den til inni formIntermediat…
taniaholst Mar 20, 2025
1523b9c
Update screenshots
taniaholst Mar 20, 2025
eb5a93a
Justerer cpu og minne for alle miljøer (#2226)
PerOlavM Mar 21, 2025
c73d9d6
frontend for tags
taniaholst Mar 17, 2025
76c8858
Legger til ekstra steg i mellomsteg og forenkler typingen noe
terjeofnorway Mar 19, 2025
b34935a
Legger til funksjon for å finne forrige tittel
terjeofnorway Mar 19, 2025
277a4d5
ny komponent LanguageDisclaimer, flyttet den til inni formIntermediat…
taniaholst Mar 20, 2025
3b2c5f2
Update screenshots
taniaholst Mar 20, 2025
5885145
justerte headerWithParent og la den inn i formIntermediateStepPage
taniaholst Mar 21, 2025
dcf1ebd
Merge branch 'mellomsteg' of github.com:navikt/nav-enonicxp-frontend …
taniaholst Mar 21, 2025
a43d869
fikset import
taniaholst Mar 21, 2025
e1d5959
la til skjemanummer inni lenkepanelene i mellomsteg for skjema
taniaholst Mar 21, 2025
0fe9e39
la til skjemanummer inni lenkepanelene i mellomsteg for skjema
taniaholst Mar 21, 2025
9a9cc07
Update screenshots
taniaholst Mar 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nais/vars/vars-dev1-failover.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ingresses:
- https://www-failover.intern.dev.nav.no
resources:
requests:
cpu: 100m
cpu: 50m
memory: 250Mi
limits:
memory: 250Mi
6 changes: 3 additions & 3 deletions .nais/vars/vars-dev1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ ingresses:
- https://www.intern.dev.nav.no
resources:
requests:
cpu: 500m
memory: 1000Mi
cpu: 100m
memory: 384Mi
limits:
memory: 2000Mi
memory: 1024Mi
valkey:
plan: hobbyist
project: nav-dev
Expand Down
2 changes: 1 addition & 1 deletion .nais/vars/vars-dev2-failover.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ingresses:
- https://www-2-failover.intern.dev.nav.no
resources:
requests:
cpu: 100m
cpu: 50m
memory: 250Mi
limits:
memory: 250Mi
6 changes: 3 additions & 3 deletions .nais/vars/vars-dev2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ ingresses:
- https://www-2.intern.dev.nav.no
resources:
requests:
cpu: 250m
memory: 500Mi
cpu: 100m
memory: 384Mi
limits:
memory: 1000Mi
memory: 1024Mi
valkey:
plan: hobbyist
project: nav-dev
Expand Down
6 changes: 3 additions & 3 deletions .nais/vars/vars-prod-failover.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ingresses:
- https://www-failover.nav.no
resources:
requests:
cpu: 500m
memory: 750Mi
cpu: 250m
memory: 512Mi
limits:
memory: 750Mi
memory: 1024Mi
2 changes: 1 addition & 1 deletion .nais/vars/vars-prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ingresses:
- https://www.nav.no
resources:
requests:
cpu: 750m
cpu: 600m
memory: 2048Mi
limits:
memory: 4096Mi
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
import type { Meta, StoryObj } from '@storybook/react';

import { FormIntermediateStepLink } from './FormIntermediateStepLink';

const meta = {
component: FormIntermediateStepLink,
} satisfies Meta<typeof FormIntermediateStepLink>;

export default meta;

type Story = StoryObj<typeof meta>;

export const Default: Story = {
args: {
label: 'Steg 1',
explanation: 'Dette er et eksempel på hva som kan stå her',
href: '/example-path',
isStepNavigation: true,
analyticsComponent: 'mellomsteg',
analyticsLinkGroup: 'Example Group',
analyticsLabel: 'Example Step',
nextStep: {
_selected: 'next',
next: {
editorial: { html: '' },
stepsHeadline: '',
steps: [],
},
},
},
};

export const LanguageDisclaimer: Story = {
args: {
label: 'Steg med språk',
explanation: 'Dette er et eksempel på hva som kan stå her',
languageDisclaimer: 'Kun på bokmål',
href: '/example-path',
isStepNavigation: true,
analyticsComponent: 'mellomsteg',
analyticsLinkGroup: 'Example Group',
analyticsLabel: 'Example Step',
nextStep: {
_selected: 'next',
next: {
editorial: { html: '' },
stepsHeadline: '',
steps: [],
},
},
},
};
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import React from 'react';
import { LinkPanel } from '@navikt/ds-react';
import { InfoBox } from 'components/_common/infoBox/InfoBox';
import { LenkeBase } from 'components/_common/lenke/lenkeBase/LenkeBase';
import { FormIntermediateStep_StepLinkData } from 'components/pages/form-intermediate-step-page/useFormIntermediateStepPageState';
import { FormIntermediateStep_StepLinkData } from 'components/pages/form-intermediate-step-page/useFormIntermediateStepPage';
import { EditorHelp } from 'components/_editor-only/editor-help/EditorHelp';
import { LanguageDisclaimer } from 'components/_common/languageDisclaimer/LanguageDisclaimer';

type Props = FormIntermediateStep_StepLinkData &
Omit<React.ComponentProps<typeof LenkeBase>, 'children' | 'href'>;
Expand All @@ -14,19 +14,19 @@ export const FormIntermediateStepLink = ({
languageDisclaimer,
href,
isStepNavigation,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
nextStep,
...rest
}: Props) => {
if (!href) {
return <EditorHelp text={'Lenken mangler URL!'} />;
}

return (
<>
{languageDisclaimer && <InfoBox>{languageDisclaimer}</InfoBox>}
<LinkPanel {...rest} as={LenkeBase} href={href} shallow={isStepNavigation}>
<LinkPanel.Title>{label}</LinkPanel.Title>
<LinkPanel.Description>{explanation}</LinkPanel.Description>
</LinkPanel>
</>
<LinkPanel {...rest} as={LenkeBase} href={href} shallow={isStepNavigation}>
<LinkPanel.Title>{label}</LinkPanel.Title>
<LinkPanel.Description>{explanation}</LinkPanel.Description>
{languageDisclaimer && <LanguageDisclaimer>{languageDisclaimer}</LanguageDisclaimer>}
</LinkPanel>
);
};
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,20 @@
font-size: 40px;
line-height: 52px;
}

.skjemanummerListe {
display: flex;
list-style: none;
padding: 0;
align-items: center;
gap: 5px;
margin: 0;
flex-wrap: wrap;

.skjemanummer {
background-color: var(--a-surface-neutral-subtle);
border-radius: 2px;
padding: 3px 6px;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,21 @@ import style from './HeaderWithParent.module.scss';

type Props = {
contentProps: Pick<ContentProps, 'data'> & {
data: Pick<ProductDataMixin, 'title' | 'illustration'>;
data: Pick<ProductDataMixin, 'title'>;
};
textAboveTitle?: string;
className?: string;
formNumbers?: string[];
};

export const HeaderWithParent = ({ contentProps, textAboveTitle, className }: Props) => {
const { data } = contentProps;
export const HeaderWithParent = ({
contentProps,
textAboveTitle,
className,
formNumbers,
}: Props) => {

const { data } = contentProps;
return (
<div className={classNames(style.headerContainer, className)}>
<BodyShort textColor="subtle" className={style.textAboveTitle}>
Expand All @@ -23,6 +29,15 @@ export const HeaderWithParent = ({ contentProps, textAboveTitle, className }: Pr
<Heading level="1" size="large" spacing className={style.header}>
{data.title}
</Heading>
{formNumbers && (
<ul className={style.skjemanummerListe}>
{formNumbers.map((nummer, index) => (
<li key={index} className={style.skjemanummer}>
{nummer}
</li>
))}
</ul>
)}
</div>
);
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
.languageDisclaimer {
display: flex;
align-items: center;
gap: 0.5rem;
margin-top: 1rem;

svg {
color: var(--a-icon-subtle);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import type { Meta, StoryObj } from '@storybook/react';

import { LanguageDisclaimer } from './LanguageDisclaimer';

const meta = {
component: LanguageDisclaimer,
} satisfies Meta<typeof LanguageDisclaimer>;

export default meta;

type Story = StoryObj<typeof meta>;

export const Default: Story = {
args: {
children: 'Kun på bokmål',
},
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { PropsWithChildren } from 'react';
import { InformationSquareIcon } from '@navikt/aksel-icons';
import style from './LanguageDisclaimer.module.scss';

export const LanguageDisclaimer = (props: PropsWithChildren) => {
return (
<div className={style.languageDisclaimer}>
<InformationSquareIcon fontSize="1.5rem" title="Informasjon" />
{props.children}
</div>
);
};
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@

.content {
grid-area: content;
margin-top: 2rem;

.linkPanels {
display: flex;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export type ContactStepPageProps = ContentCommonProps & {
linkPanelsSubHeading: string;
linkPanels: (InternalLinkMixin & { ingress?: string })[];
backLink: InternalLinkMixin;
formNumbers?: string[];
};
};

Expand All @@ -33,15 +34,17 @@ export const ContactStepPage = ({ data }: ContactStepPageProps) => {
linkPanelsSubHeading,
linkPanels,
backLink,
formNumbers,
} = data;

return (
<div className={style.contactStepPage}>
<IllustrationStatic illustration={illustration} className={style.pictogram} />
<HeaderWithParent
contentProps={{ data: { title, illustration } }}
contentProps={{ data: { title } }}
textAboveTitle={textAboveTitle}
className={style.header}
formNumbers={formNumbers}
/>
<div className={style.content}>
<ParsedHtml htmlProps={html} />
Expand Down
Loading
Loading