Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/handle 404 for mellomlagring #1011

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

magnurh-cx
Copy link
Contributor

No description provided.

@magnurh-cx magnurh-cx requested a review from a team as a code owner February 6, 2024 07:57
Copy link
Member

@akgagnat akgagnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💾

true,
);
if (isNotFound(sendInnResponse, responseError)) {
return res.sendStatus(404);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Burde vi logge noe her?

{mellomlagringError.linkText && (
<p>
{translate(mellomlagringError.messageStart)}
<a href={mellomlagringError.url}>{mellomlagringError.linkText}</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oversettelse

@@ -220,15 +220,22 @@ export interface FormsResponseForm extends Pick<NavFormType, '_id' | 'title' | '
export type SubmissionData = Record<string, string | number | boolean | any[] | object>;

type ErrorType =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

litt rart at disse typene ligger i shared-domain, men kanskje utenfor scope av denne oppgaven

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kom på hvorfor. Disse typene brukes av fyllutState som er del av Submission.

@magnurh-cx magnurh-cx merged commit c81c708 into master Feb 6, 2024
@magnurh-cx magnurh-cx deleted the feature/handle-404-for-mellomlagring branch February 6, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants