-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Valider valgt navSelect-verdi i mellomlagret søknad #1020
Merged
akgagnat
merged 11 commits into
master
from
nav-select-submission-value-removed-from-values
Mar 7, 2024
Merged
Valider valgt navSelect-verdi i mellomlagret søknad #1020
akgagnat
merged 11 commits into
master
from
nav-select-submission-value-removed-from-values
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailable in values for that navSelect component. Will show message about missing information on summary page, and the user must choose a valid value before continuing. Also take into account that 'landvelger' and 'valutavelger' fetches data async.
magnurh-cx
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤳 👍 💯
packages/shared-components/src/formio/components/core/select/Select.tsx
Outdated
Show resolved
Hide resolved
…hed in init function, not necessary to fetch in render.
…tavelger' because there is a bug within the validation that occurs on the summary page, which leads to the user being prevented from submitting a complete application. It applies to these two components since their values are fetched asynchronous, and the component's 'get ready'-promise is not respected for some reason (when display='wizard'), resulting in validation running before values are fetched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.