Feature/refaktorering ettersending #1479
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnurh-cx
reviewed
Mar 14, 2025
nurrebass1
force-pushed
the
feature/refaktorering-ettersending
branch
3 times, most recently
from
9bde040 to
28665b8
Compare
magnurh-cx
reviewed
Mar 18, 2025
| @@ -341,7 +341,7 @@ describe('Migration scripts', () => { | |||
| ...originalForm.properties, | |||
| skjemanummer: 'Form1', | |||
| submissionTypes: ['DIGITAL'], | |||
| ettersending: undefined, | |||
| subsequentSubmissionTypes: [], | |||
There was a problem hiding this comment.
Default verdi er ['PAPER', 'DIGITAL']
magnurh-cx
approved these changes
Mar 18, 2025
| @@ -11,15 +11,18 @@ const createHeaders = (accessToken?: string, revisionId?: number) => { | |||
| }; | |||
| }; | |||
|
|
|||
| export const removeInnsendingFromForm = (form: Form): Form => { | |||
| const formProperties = (({ innsending, ...rest }) => rest)(form.properties); | |||
| export const removeInnsendingTypeFromForm = (form: Form): Form => { | |||
There was a problem hiding this comment.
Vurder å legge til kommentar her for å forklare at denne funksjonen er her for å støtte bakoverkompatibilitet og kan fjernes når alle skjemadefinisjoner er oppdatert.
| @@ -3375,6 +3375,7 @@ | |||
| "skjemanummer": "TST-123456", | |||
| "tema": "DAG", | |||
| "submissionTypes": ["PAPER", "DIGITAL"], | |||
| "subsequentSubmissionTypes": [], | |||
There was a problem hiding this comment.
Suggested change
| "subsequentSubmissionTypes": [], | |
| "subsequentSubmissionTypes": ["PAPER", "DIGITAL"], |
| @@ -3508,6 +3508,7 @@ | |||
| "skjemanummer": "TST-123456", | |||
| "tema": "DAG", | |||
| "submissionTypes": ["PAPER", "DIGITAL"], | |||
| "subsequentSubmissionTypes": [], | |||
There was a problem hiding this comment.
Suggested change
| "subsequentSubmissionTypes": [], | |
| "subsequentSubmissionTypes": ["PAPER", "DIGITAL"], |
| @@ -50,8 +50,9 @@ const mapLimitedForm = (form: NavFormType, translate: TranslateFunction) => { | |||
| properties: { | |||
| skjemanummer: form.properties.skjemanummer, | |||
| tema: form.properties.tema, | |||
| innsending: form.properties.innsending, | |||
| submissionTypes: form.properties.submissionTypes, | |||
| ettersending: form.properties.ettersending, | |||
There was a problem hiding this comment.
Skal innsending ligge her?
innsending og ettersending bør fjernes når fyllut-ettersending er oppdatert
| @@ -10,7 +10,7 @@ const mapForm = (form): FormsResponseForm => ({ | |||
| properties: { | |||
| skjemanummer: form.skjemanummer ?? form.properties.skjemanummer, | |||
| submissionTypes: form.properties.submissionTypes, | |||
| ettersending: form.properties.ettersending, | |||
| subsequentSubmissionTypes: form.properties.subsequentSubmissionTypes, | |||
There was a problem hiding this comment.
Bør denne ha ettersending i tillegg?
magnurh-cx
approved these changes
Mar 21, 2025
| submissionTypes: | ||
| form.properties.submissionTypes ?? mapInnsendingTypeToSubmissionTypes(form.properties.innsending), | ||
| subsequentSubmissionTypes: | ||
| form.properties.subsequentSubmissionTypes ?? mapInnsendingTypeToSubmissionTypes(form.properties.ettersending), |
There was a problem hiding this comment.
Legg til en sjekk før vi kjører mapInnsendingTypeToSubmission. Hvis form.properties.ettersending er undefined, setter vi ['PAPER', 'DIGITAL'], ellers gjør vi mapping.
nurrebass1
force-pushed
the
feature/refaktorering-ettersending
branch
3 times, most recently
from
da9e5d3 to
648dd28
Compare
nurrebass1
force-pushed
the
feature/refaktorering-ettersending
branch
from
648dd28 to
feb6b4e
Compare
nurrebass1
force-pushed
the
feature/refaktorering-ettersending
branch
from
feb6b4e to
27af1d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.