-
Notifications
You must be signed in to change notification settings - Fork 3
Store motebehov formSnapshot and V4 controllers #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be69d7d
to
5e50b87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 22 out of 42 changed files in this pull request and generated no comments.
Files not reviewed (20)
- detekt-baseline.xml: Language not supported
- src/main/kotlin/no/nav/syfo/metric/Metric.kt: Language not supported
- src/main/kotlin/no/nav/syfo/motebehov/ConvertLegacyMotebehovSvarFieldsHelper.kt: Language not supported
- src/main/kotlin/no/nav/syfo/motebehov/Motebehov.kt: Language not supported
- src/main/kotlin/no/nav/syfo/motebehov/MotebehovFormValuesDTOs.kt: Language not supported
- src/main/kotlin/no/nav/syfo/motebehov/MotebehovOppfolgingstilfelleServiceV2.kt: Language not supported
- src/main/kotlin/no/nav/syfo/motebehov/MotebehovService.kt: Language not supported
- src/main/kotlin/no/nav/syfo/motebehov/MotebehovSvar.kt: Language not supported
- src/main/kotlin/no/nav/syfo/motebehov/NyttMotebehov.kt: Language not supported
- src/main/kotlin/no/nav/syfo/motebehov/NyttMotebehovArbeidsgiverDTO.kt: Language not supported
- src/main/kotlin/no/nav/syfo/motebehov/api/MotebehovArbeidsgiverControllerV3.kt: Language not supported
- src/main/kotlin/no/nav/syfo/motebehov/api/MotebehovArbeidsgiverControllerV4.kt: Language not supported
- src/main/kotlin/no/nav/syfo/motebehov/api/MotebehovArbeidstakerControllerV3.kt: Language not supported
- src/main/kotlin/no/nav/syfo/motebehov/api/MotebehovArbeidstakerControllerV4.kt: Language not supported
- src/main/kotlin/no/nav/syfo/motebehov/api/internad/dto/MotebehovVeilederDTO.kt: Language not supported
- src/main/kotlin/no/nav/syfo/motebehov/api/internad/v3/MotebehovVeilederADControllerV3.kt: Language not supported
- src/main/kotlin/no/nav/syfo/motebehov/api/internad/v4/MotebehovVeilederADControllerV4.kt: Language not supported
- src/main/kotlin/no/nav/syfo/motebehov/database/MotebehovDAO.kt: Language not supported
- src/main/kotlin/no/nav/syfo/motebehov/database/PMotebehov.kt: Language not supported
- src/main/kotlin/no/nav/syfo/motebehov/formSnapshot/FomSnapshotFieldIds.kt: Language not supported
MalazAlkoj
reviewed
Apr 2, 2025
src/main/kotlin/no/nav/syfo/motebehov/api/internad/dto/MotebehovVeilederDTO.kt
Show resolved
Hide resolved
MalazAlkoj
reviewed
Apr 2, 2025
src/main/kotlin/no/nav/syfo/motebehov/api/internad/v4/MotebehovVeilederADControllerV4.kt
Show resolved
Hide resolved
AudunSorheim
reviewed
Apr 3, 2025
src/main/kotlin/no/nav/syfo/motebehov/formSnapshot/FormSnapshotJSONConversion.kt
Show resolved
Hide resolved
Some renaming and refactoring: - Rename formFillout to formSnapshot - Rename motebehovSvar fields that are not in DTOs to formValues - Move some mapping functions in MotebehovService to PMotebehov
…d MotebehovServiceTest Also a lot of renaming of classes and fields
And some renaming
43a47a7
to
782da57
Compare
ce8f25b
to
2d40c9b
Compare
MalazAlkoj
reviewed
Apr 7, 2025
src/main/kotlin/no/nav/syfo/motebehov/formSnapshot/FormSnapshotJSONConversion.kt
Show resolved
Hide resolved
MalazAlkoj
reviewed
Apr 8, 2025
MalazAlkoj
reviewed
Apr 8, 2025
MalazAlkoj
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, but we can merge also.
c97ad6b
to
1dbf738
Compare
And remove now superfluous registration of deserializer for objectMapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.