Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS: Refactor oppfolgingsoppgaveservice #528

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

vetlesolgaard
Copy link
Contributor

@vetlesolgaard vetlesolgaard commented Mar 28, 2025

Hva har blitt lagt til✨🌈

  • Flytter noen queries inn i PersonOversiktStatusRepository
  • Fjerner DatabaseInterface bruk fra OppfolgingsoppgaveService
  • Flytter mer av håndtering av records inn i OppfolgingsoppgaveConsumer

Ikke sikkert alle endringer er så enkle å lese, så si ifra så kan vi se på PR'en sammen heller 🙌

@vetlesolgaard vetlesolgaard requested a review from a team as a code owner March 28, 2025 07:23
@@ -17,6 +17,7 @@ const val queryGetPersonOversiktStatusList =
WHERE fnr = ?
"""

// Deprecated: Use getPersonOversiktStatus in PersonOversiktStatusRepository instead
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hva med følgende i stedet?

Suggested change
// Deprecated: Use getPersonOversiktStatus in PersonOversiktStatusRepository instead
@Deprecated("Use getPersonOversiktStatus in PersonOversiktStatusRepository instead")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mye bedre! 🤌

@vetlesolgaard vetlesolgaard force-pushed the IS-Refactor-oppfolgingsoppgaveservice branch from 46c1b1e to 45b519c Compare March 28, 2025 09:52
@vetlesolgaard vetlesolgaard merged commit 9b231d1 into master Mar 28, 2025
3 checks passed
@vetlesolgaard vetlesolgaard deleted the IS-Refactor-oppfolgingsoppgaveservice branch March 28, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants