Feature/kodeverk service #3449
Merged
Feature/kodeverk service #3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…everk-service Removed KodeverkMapper and TokenXUtil classes, switched Flux to Mono in KodeverkGetCommand, and enhanced the logging in KodeverkController for better insight during runtime. Additionally, various dependencies in build.gradle and imports in other classes have been updated or removed to tidy up the project structure. This refactoring is aimed to simplify the code structure, enhance application performace and improve debugging during operation.
…rvice Added CacheConfig.java for defining cache configurations and enabled caching annotations in KodeverkService. Implemented Caffeine and NoOpCacheManager for 'prod' and 'dev' profiles respectively. Additionally, updated some method arguments and return types in KodeverkService and added 'spring-boot-starter-cache' along with caffeine library in build.gradle dependencies. This optimization aims to improve application performance by reducing redundant data fetching operations.
…verk-service The security setup has been switched to reactive by including 'reactive-security' and replacing 'servlet-security' with 'reactive-core'. Changes in 'AppConfig.java', 'build.gradle', and 'settings.gradle' reflect this. Also, the 'SecurityConfig.java' has been reordered and updated to utilize the reactive method security. The 'failureThreshold' for liveness and readiness in 'config.yml' has been reduced for faster response. Lastly, the libraries in 'KodeverkConsumer.java' have also been updated to reflect the changes.
…#deploy-kodeverk-service The used Springdoc OpenAPI starter dependency was switched from 'springdoc-openapi-starter-webmvc-ui' to 'springdoc-openapi-starter-webflux-ui' making the application more reactive. Alongside this main change, the 'OpenApiConfig.java' was adjusted to implement 'WebFilter', changing the handling of authentication headers and introducing a new method for routing '/swagger' requests to '/swagger-ui.html'.
Modified the endpoint mapping in KodeverkController.java to remove '/kodeverk'. This change simplifies the request paths, with the retrieval method determined by the presence or absence of a path variable. Now, the main endpoint and the specific 'kodeverkNavn' endpoints are directly accessible from the root.
The commit removes 'servlet-core', 'servlet-security' and 'testing' dependencies from the trigger paths. Additionally, 'reactive-security' has been added to the trigger paths for the GitHub workflow in 'app.kodeverk-service.yml'.
A second cache, "kodeverk-2", has been introduced in CacheConfig. The CaffeineCacheManager now also manages this new cache. Additionally, the "getKodeverkByName" method in KodeverkController has been updated to use "kodeverk-2" for caching instead of the original "kodeverk".
The caching rule for CACHE_KODEVERK and CACHE_KODEVERK_2 in KodeverkController has been updated to avoid caching empty results. This helps to optimize cache storage and enhance the performance of the Kodeverk service.
…loy-kodeverk-service The commit introduces new Data Transfer Objects (DTOs) to Kodeverk service, revamping the Kodeverk controller and service accordingly. Additionally, the caching rules have been refined for the Kodeverk service to evade storing empty results, thereby optimizing cache utilization and enhancing overall performance.
…k-service The commit changes the assignments for the label and value properties of KodeAdjusted in KodeverkService. Now, it uses getNorskBokmaal for the label and the map's key for the value, adjusting the data assignment logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.