Skip to content

Feature/bestilling fra skattekort service #3573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 5, 2024

Conversation

krharum
Copy link
Contributor

@krharum krharum commented Aug 2, 2024

No description provided.

krharum added 3 commits August 2, 2024 12:22
#deploy-skattekort-service

Updated the inbound rules in the skattekort-service config.yml to include additional applications: dolly-backend-dev, dolly-frontend-dev, and team-dolly-lokal-app. This allows better control and access for these new applications.
This update introduces skattekort processing in the bestilling service. New functionalities include mapping skattekort status, handling skattekort requests, and updating related configurations.
#deploy-test-dolly-backend

Enhance bestilling service to process skattekort errors. Modify the handling of skattekort statuses, returning detailed error reports when errors occur. Integrate new dependency imports and clean up deprecated code.
@krharum krharum marked this pull request as ready for review August 5, 2024 05:38
@krharum krharum requested a review from a team as a code owner August 5, 2024 05:38
krharum added 6 commits August 5, 2024 07:57
#deploy-test-dolly-backend

Enhanced bestilling service by filtering out null skattekort entries before processing. This prevents null pointers and ensures only valid skattekort data moves forward in the pipeline. Added necessary imports to support the new check.
#deploy-test-dolly-backend

Introduced SkattekortRequestDTO and integrated it into existing packages. Added a new mapping strategy to map DTO fields for skattekort service requests. This enhances the flexibility and extensibility of our code related to skattekort functionality.
#deploy-test-dolly-backend

Introduced SkattekortRequestDTO and integrated it into existing packages. Added a new mapping strategy to map DTO fields for skattekort service requests. This enhances the flexibility and extensibility of our code related to skattekort functionality.
#deploy-skattekort-service #deploy-test-dolly-backend

Renamed the Arbeidsgiver class to ArbeidsgiverSkatt for clarity and improved domain specificity. Updated all occurrences and references in DTOs to reflect the change. This ensures consistency across the codebase and improves readability.
#deploy-skattekort-service

Replaced all occurrences of "Arbeidsgiver" with "ArbeidsgiverSkatt" in service, utility, and DTO classes. This change aligns the codebase with updated naming conventions and ensures consistency across different modules.
@krharum krharum merged commit 02bb18a into master Aug 5, 2024
25 checks passed
@krharum krharum deleted the feature/bestilling-fra-skattekort-service branch August 5, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant