Feature/inntektstub fjerne miljoe orgnummer #3796
Merged
+246
−287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#deploy-organisasjon-forvalter
#deploy-organisasjon-forvalter
#deploy-organisasjon-forvalter
- Refactor manualChangeOrg to better handle the different implementations - useDollyOrganisasjoner fix for different amount of hooks rendered bug that happened occasionally - Lesser updates and refactoring
#deploy-test-frontend
betsytraran
reviewed
Mar 17, 2025
There was a problem hiding this comment.
Ser ikke ut til at "Skriv inn org.nr." funker så veldig bra? 🤔
- Brregstub: Om jeg skriver inn et orgnr som ikke finnes, vises ingen feilmelding, og jeg får gå videre. Om jeg går tilbake vises fortsatt orgnr i feltet, men det er slettet fra form, så da får jeg feilmelding om at feltet er påkrevd.
- Inntektstub: Om jeg skriver inn et orgnr som ikke finnes, vises ikke feilmelding, men feltet blir rødt. Feilmeldingen som ikke blir vist er at opplysningspliktig mangler.
- Skattekort: Om jeg skriver inn et orgnr som ikke finnes, vises ingen feilmelding, og jeg får gå videre. Når jeg går tilbake er fortsatt orgnr i form, men nå har jeg fått feilmeldingen "Organisasjonen må være av type BEDR eller AAFY" (men den skulle vel vært at org ikke finnes?).
#deploy-organisasjon-forvalter
Legger til feilhåndtering og forbedrer organisasjonsvalg i skjema #deploy-test-frontend
Legger til feilhåndtering og forbedrer organisasjonsvalg i skjema #deploy-test-frontend
Ja denne krevde en samsvarende endring i org-forvalter for å fungere riktig, men deploy av den var blitt overskrevet, så juridisk org ble ikke satt ved manuell input 😅 Feilhandling var dog ikke så robust, har fikset det nå, bra funnet 😄 |
# Conflicts: # apps/dolly-frontend/src/main/js/package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to several dependencies in the
package-lock.jsonfile, ensuring that the project uses the latest versions of these packages.Dependency updates:
@babelpackages to version7.26.10from7.26.9to include the latest fixes and improvements. (apps/dolly-frontend/src/main/js/package-lock.json) [1] [2] [3] [4] [5]@eslint-community/eslint-utilsto version4.5.1from4.4.1to incorporate the latest updates. (apps/dolly-frontend/src/main/js/package-lock.json)@naviktpackages (aksel-icons,ds-css,ds-react,ds-tokens) to version7.17.2from7.17.1for the latest features and bug fixes. (apps/dolly-frontend/src/main/js/package-lock.json) [1] [2] [3]@typescript-eslintpackages to version8.26.1from8.26.0to ensure compatibility and improvements. (apps/dolly-frontend/src/main/js/package-lock.json) [1] [2] [3] [4] [5] [6] [7] [8]axiosto version1.8.3from1.8.2to include the latest security patches and enhancements. (apps/dolly-frontend/src/main/js/package-lock.json)babel-plugin-react-compilerto version19.0.0-beta-bafa41b-20250307from19.0.0-beta-40c6c23-20250301for the latest updates. (apps/dolly-frontend/src/main/js/package-lock.json)