Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legger til en convenience "connector" inn i pod'ene vha. kubectl, for å unngå situasjoner der lokal testing avhenger av en verdi satt i environment i pod. Konfigurerte environment-variabler hentes ut og settes når applikasjonen starter lokalt.
Avhenger selvsagt av innlogging i gcloud og naisdevice, men skal være ganske fail safe, dvs. logger og fortsetter. Og påvirker kun local profiles.
Copilot:
This pull request introduces several configuration updates and enhancements to the environment setup across multiple services. The changes primarily focus on adding new environment variables and improving the dynamic loading of environment variables from the NAIS environment.
Configuration Updates:
proxies/aareg-proxy/src/main/resources/application-local.yml
: Added NAIS configuration fordolly.nais.cluster
,dolly.nais.name
, anddolly.nais.variables
.NAIS Environment Enhancements:
libs/testing/src/main/java/no/nav/dolly/libs/nais/NaisEnvironmentApplicationContextInitializer.java
: Modified methods to useConfigurableEnvironment
instead ofMap<String, Object>
for better environment management. [1] [2] [3] [4]libs/testing/src/main/java/no/nav/dolly/libs/nais/NaisEnvironmentException.java
: Added a new exception class to handle NAIS environment errors.libs/testing/src/main/java/no/nav/dolly/libs/nais/NaisRuntimeEnvironmentConnector.java
: Introduced a new class to dynamically load environment variables from the NAIS environment.libs/testing/src/main/resources/META-INF/additional-spring-configuration-metadata.json
: Added metadata for new NAIS configuration properties.