-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat. legg til diskresjonskoder for Vikafossen i oversikten #1305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for diskresjonskoder to display coded information (Kode‑6/7) for Vikafossen in the agreement overview.
- Introduces the new NavnMedDiskresjonskode component to render participant names along with their diskresjonskode.
- Updates AvtalekortMobil and AvtaleTabell to utilize the new component for consistent display.
- Adjusts type definitions and applies minor styling changes in table headers and status labels.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/AvtaleOversikt/NavnMedDiskresjonskode.tsx | New component for rendering names with diskresjonskode. |
src/AvtaleOversikt/AvtalekortMobil.tsx | Modified mobile card display to use NavnMedDiskresjonskode. |
src/AvtaleOversikt/AvtaleTabell.tsx | Replaced inline name-building with NavnMedDiskresjonskode. |
src/AvtaleOversikt/AvtaleTabellRadHeader.tsx | Updated participant column header with a fixed width style. |
src/BeslutterSide/EtikettStatus.tsx | Added a CSS class to the Tag component for consistent styling. |
src/types/avtale.ts | Extended agreement types to include diskresjonskode. |
Files not reviewed (1)
- src/AvtaleOversikt/AvtaleTabell.less: Language not supported
Comments suppressed due to low confidence (2)
src/AvtaleOversikt/NavnMedDiskresjonskode.tsx:12
- [nitpick] Consider using template literals for string concatenation to improve readability, e.g.
return
${deltakerFornavn} ${deltakerEtternavn};
.
return deltakerFornavn + ' ' + deltakerEtternavn;
src/AvtaleOversikt/AvtaleTabellRadHeader.tsx:24
- [nitpick] Consider extracting the inline style into a dedicated CSS class for consistency and easier maintenance.
<Table.ColumnHeader style={{ width: '15%' }}>
22d88e0
to
1130935
Compare
1130935
to
3161bff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ellers bra 👏
Hent diskresjonskoder fra PDL for å vise kode-6/7 for Vikafossen i avtale-oversikten
3161bff
to
6726fe1
Compare
Hent diskresjonskoder fra PDL for å vise kode-6/7 for Vikafossen i avtale-oversikten