Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat. legg til diskresjonskoder for Vikafossen i oversikten #1305

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

eirikv
Copy link
Contributor

@eirikv eirikv commented Mar 18, 2025

Hent diskresjonskoder fra PDL for å vise kode-6/7 for Vikafossen i avtale-oversikten

@eirikv eirikv requested review from Oddsor, MagnusRom and Copilot March 18, 2025 14:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for diskresjonskoder to display coded information (Kode‑6/7) for Vikafossen in the agreement overview.

  • Introduces the new NavnMedDiskresjonskode component to render participant names along with their diskresjonskode.
  • Updates AvtalekortMobil and AvtaleTabell to utilize the new component for consistent display.
  • Adjusts type definitions and applies minor styling changes in table headers and status labels.

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/AvtaleOversikt/NavnMedDiskresjonskode.tsx New component for rendering names with diskresjonskode.
src/AvtaleOversikt/AvtalekortMobil.tsx Modified mobile card display to use NavnMedDiskresjonskode.
src/AvtaleOversikt/AvtaleTabell.tsx Replaced inline name-building with NavnMedDiskresjonskode.
src/AvtaleOversikt/AvtaleTabellRadHeader.tsx Updated participant column header with a fixed width style.
src/BeslutterSide/EtikettStatus.tsx Added a CSS class to the Tag component for consistent styling.
src/types/avtale.ts Extended agreement types to include diskresjonskode.
Files not reviewed (1)
  • src/AvtaleOversikt/AvtaleTabell.less: Language not supported
Comments suppressed due to low confidence (2)

src/AvtaleOversikt/NavnMedDiskresjonskode.tsx:12

  • [nitpick] Consider using template literals for string concatenation to improve readability, e.g. return ${deltakerFornavn} ${deltakerEtternavn};.
return deltakerFornavn + ' ' + deltakerEtternavn;

src/AvtaleOversikt/AvtaleTabellRadHeader.tsx:24

  • [nitpick] Consider extracting the inline style into a dedicated CSS class for consistency and easier maintenance.
<Table.ColumnHeader style={{ width: '15%' }}>

@eirikv eirikv force-pushed the feat/diskresjonskode-veileder-oversikt branch from 22d88e0 to 1130935 Compare March 18, 2025 14:32
@eirikv
Copy link
Contributor Author

eirikv commented Mar 18, 2025

image

@eirikv eirikv force-pushed the feat/diskresjonskode-veileder-oversikt branch from 1130935 to 3161bff Compare March 20, 2025 07:26
Copy link
Contributor

@Oddsor Oddsor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ellers bra 👏

eirikv added 2 commits March 25, 2025 10:46
Hent diskresjonskoder fra PDL for å vise kode-6/7 for Vikafossen
i avtale-oversikten
@eirikv eirikv force-pushed the feat/diskresjonskode-veileder-oversikt branch from 3161bff to 6726fe1 Compare March 25, 2025 10:09
@eirikv eirikv merged commit 69f119a into master Mar 25, 2025
1 check passed
@eirikv eirikv deleted the feat/diskresjonskode-veileder-oversikt branch March 25, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants