Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat. vise diskresjonskoder til besluttere på oversikten #1308

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

eirikv
Copy link
Contributor

@eirikv eirikv commented Mar 24, 2025

No description provided.

@eirikv eirikv requested review from Copilot and a team March 24, 2025 07:25
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new feature to display discretion codes to decision makers on the overview page. The changes include updating the table component to utilize a dedicated NavnMedDiskresjonskode component for rendering participant names with discretion codes and extending the agreement type to include a discretion code field.

  • Updating the name rendering to incorporate discretion codes.
  • Extending the data type to include a new diskresjonskode property.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/BeslutterOversikt/AvtaleTabellBeslutter.tsx Replaced manual concatenation of first and last names with the NavnMedDiskresjonskode component to include discretion codes.
src/types/avtale.ts Added the diskresjonskode property to the AvtaleMinimalForBeslutter type to support the new feature.
Comments suppressed due to low confidence (2)

src/BeslutterOversikt/AvtaleTabellBeslutter.tsx:55

  • Consider adding unit tests for the new diskresjonskode display feature to verify that it renders correctly with various input scenarios.
<NavnMedDiskresjonskode

src/types/avtale.ts:76

  • [nitpick] Ensure that the type Diskresjonskode is well defined and consistently named throughout the codebase to clearly reflect its domain purpose.
diskresjonskode: Diskresjonskode;

@eirikv eirikv force-pushed the feat/diskresjonskode-veileder-oversikt branch from 3161bff to 6726fe1 Compare March 25, 2025 10:09
Base automatically changed from feat/diskresjonskode-veileder-oversikt to master March 25, 2025 11:00
@eirikv eirikv force-pushed the feat/diskresjonskode-beslutter-oversikt branch from f55a80d to 8a26ba1 Compare March 25, 2025 11:01
@eirikv eirikv merged commit f659b29 into master Mar 25, 2025
1 check passed
@eirikv eirikv deleted the feat/diskresjonskode-beslutter-oversikt branch March 25, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants