Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advarsel ved registrering av vtao avtaler #1313

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

henriktheboss
Copy link
Contributor

@henriktheboss henriktheboss commented Mar 26, 2025

image

@henriktheboss henriktheboss requested a review from Copilot March 26, 2025 13:56
@henriktheboss henriktheboss self-assigned this Mar 26, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the alert component for "vtao" agreements by introducing dynamic migration dates based on the agreement type and updating the warning text accordingly.

  • Introduces dynamic migration dates and checks based on the tiltakstype.
  • Updates the alert message to display the formatted migration date.
  • Adjusts class naming for alert content styling.
Files not reviewed (1)
  • src/AvtaleSide/steg/VarighetSteg/varighetSteg.less: Language not supported
Comments suppressed due to low confidence (2)

src/AvtaleSide/steg/VarighetSteg/InfoArenaOppryddingAlert.tsx:23

  • [nitpick] Consider renaming 'migreringsdato' to a more descriptive name like 'migreringCutoffDate' to better reflect its purpose.
let migreringsdato: string | undefined = undefined;

src/AvtaleSide/steg/VarighetSteg/InfoArenaOppryddingAlert.tsx:28

  • [nitpick] Consider externalizing the hard-coded migration date '2025-07-01' into a configuration constant to improve maintainability.
migreringsdato = '2025-07-01';

@henriktheboss henriktheboss requested a review from MagnusRom March 26, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant