Skip to content

Legg til hentEnkelPersonForFnr i personService og bruk denne i hentPersonopplysningerRoutes #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import no.nav.tiltakspenger.libs.common.SakId
import no.nav.tiltakspenger.libs.common.SøknadId
import no.nav.tiltakspenger.libs.common.VedtakId
import no.nav.tiltakspenger.saksbehandling.domene.sak.Saksnummer
import no.nav.tiltakspenger.vedtak.clients.person.PersonService
import java.lang.String.join
import java.util.UUID

Expand Down
Original file line number Diff line number Diff line change
@@ -1,17 +1,21 @@
package no.nav.tiltakspenger.vedtak.auditlog
package no.nav.tiltakspenger.vedtak.clients.person

import kotlinx.coroutines.runBlocking
import no.nav.tiltakspenger.felles.exceptions.IkkeFunnetException
import no.nav.tiltakspenger.libs.common.BehandlingId
import no.nav.tiltakspenger.libs.common.Fnr
import no.nav.tiltakspenger.libs.common.MeldekortId
import no.nav.tiltakspenger.libs.common.SakId
import no.nav.tiltakspenger.libs.common.SøknadId
import no.nav.tiltakspenger.libs.common.VedtakId
import no.nav.tiltakspenger.saksbehandling.domene.personopplysninger.EnkelPerson
import no.nav.tiltakspenger.saksbehandling.domene.sak.Saksnummer
import no.nav.tiltakspenger.saksbehandling.ports.PersonGateway
import no.nav.tiltakspenger.vedtak.repository.person.PersonRepo

class PersonService(
private val personRepo: PersonRepo,
private val personClient: PersonGateway,
) {

fun hentFnrForBehandlingId(behandlingId: BehandlingId): Fnr =
Expand All @@ -37,4 +41,6 @@ class PersonService(
fun hentFnrForSøknadId(søknadId: SøknadId): Fnr =
personRepo.hentFnrForSøknadId(søknadId)
?: throw IkkeFunnetException("Fant ikke fnr på søknadId: søknadId")

fun hentEnkelPersonForFnr(fnr: Fnr): EnkelPerson = runBlocking { personClient.hentEnkelPerson(fnr) }
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ import no.nav.tiltakspenger.saksbehandling.service.personopplysning.Personopplys
import no.nav.tiltakspenger.saksbehandling.service.personopplysning.PersonopplysningServiceImpl
import no.nav.tiltakspenger.vedtak.Configuration
import no.nav.tiltakspenger.vedtak.auditlog.AuditService
import no.nav.tiltakspenger.vedtak.auditlog.PersonService
import no.nav.tiltakspenger.vedtak.auth.AzureTokenProvider
import no.nav.tiltakspenger.vedtak.clients.person.PersonHttpklient
import no.nav.tiltakspenger.vedtak.clients.person.PersonService
import no.nav.tiltakspenger.vedtak.repository.person.PersonRepo
import no.nav.tiltakspenger.vedtak.repository.person.PersonRepoImpl
import no.nav.tiltakspenger.vedtak.repository.sak.PersonopplysningerPostgresRepo
Expand Down Expand Up @@ -42,11 +42,15 @@ open class PersonContext(
sessionFactory = sessionFactory as PostgresSessionFactory,
)
}
val personService by lazy {
PersonService(
personRepo = personRepo,
personClient = personGateway,
)
}
val auditService by lazy {
AuditService(
PersonService(
personRepo = personRepo,
),
personService,
)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,10 @@ internal fun Application.vedtakApi(
innloggetSaksbehandlerProvider = innloggetSaksbehandlerProvider,
behandlingService = applicationContext.førstegangsbehandlingContext.behandlingService,
sakService = applicationContext.sakContext.sakService,
personService = applicationContext.personContext.personService,
kvpVilkårService = applicationContext.førstegangsbehandlingContext.kvpVilkårService,
livsoppholdVilkårService = applicationContext.førstegangsbehandlingContext.livsoppholdVilkårService,
auditService = applicationContext.personContext.auditService,
personGateway = applicationContext.personContext.personGateway,
)
behandlingBenkRoutes(
innloggetSaksbehandlerProvider = innloggetSaksbehandlerProvider,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ import mu.KotlinLogging
import no.nav.tiltakspenger.felles.Saksbehandler
import no.nav.tiltakspenger.felles.sikkerlogg
import no.nav.tiltakspenger.libs.common.BehandlingId
import no.nav.tiltakspenger.saksbehandling.ports.PersonGateway
import no.nav.tiltakspenger.saksbehandling.service.behandling.BehandlingService
import no.nav.tiltakspenger.saksbehandling.service.behandling.vilkår.kvp.KvpVilkårService
import no.nav.tiltakspenger.saksbehandling.service.behandling.vilkår.livsopphold.LivsoppholdVilkårService
import no.nav.tiltakspenger.saksbehandling.service.sak.SakService
import no.nav.tiltakspenger.vedtak.auditlog.AuditLogEvent
import no.nav.tiltakspenger.vedtak.auditlog.AuditService
import no.nav.tiltakspenger.vedtak.clients.person.PersonService
import no.nav.tiltakspenger.vedtak.routes.behandling.personopplysninger.hentPersonRoute
import no.nav.tiltakspenger.vedtak.routes.behandling.stønadsdager.stønadsdagerRoutes
import no.nav.tiltakspenger.vedtak.routes.behandling.vilkår.alder.alderRoutes
Expand All @@ -39,10 +39,10 @@ fun Route.behandlingRoutes(
innloggetSaksbehandlerProvider: InnloggetSaksbehandlerProvider,
behandlingService: BehandlingService,
sakService: SakService,
personService: PersonService,
kvpVilkårService: KvpVilkårService,
livsoppholdVilkårService: LivsoppholdVilkårService,
auditService: AuditService,
personGateway: PersonGateway,
) {
get("$BEHANDLING_PATH/{behandlingId}") {
sikkerlogg.debug("Mottatt request på $BEHANDLING_PATH/behandlingId")
Expand Down Expand Up @@ -100,7 +100,7 @@ fun Route.behandlingRoutes(
call.respond(message = "{}", status = HttpStatusCode.OK)
}

hentPersonRoute(innloggetSaksbehandlerProvider, sakService, personGateway, auditService)
hentPersonRoute(innloggetSaksbehandlerProvider, sakService, personService, auditService)
tiltakDeltagelseRoutes(innloggetSaksbehandlerProvider, behandlingService, auditService)
institusjonsoppholdRoutes(innloggetSaksbehandlerProvider, behandlingService, auditService)
kvpRoutes(innloggetSaksbehandlerProvider, kvpVilkårService, behandlingService, auditService)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,20 @@ import io.ktor.server.plugins.callid.callId
import io.ktor.server.response.respond
import io.ktor.server.routing.Route
import io.ktor.server.routing.get
import kotlinx.coroutines.runBlocking
import no.nav.tiltakspenger.felles.sikkerlogg
import no.nav.tiltakspenger.libs.common.SakId
import no.nav.tiltakspenger.saksbehandling.ports.PersonGateway
import no.nav.tiltakspenger.saksbehandling.service.sak.SakService
import no.nav.tiltakspenger.vedtak.auditlog.AuditLogEvent
import no.nav.tiltakspenger.vedtak.auditlog.AuditService
import no.nav.tiltakspenger.vedtak.clients.person.PersonService
import no.nav.tiltakspenger.vedtak.routes.parameter
import no.nav.tiltakspenger.vedtak.routes.sak.SAK_PATH
import no.nav.tiltakspenger.vedtak.tilgang.InnloggetSaksbehandlerProvider

fun Route.hentPersonRoute(
innloggetSaksbehandlerProvider: InnloggetSaksbehandlerProvider,
sakService: SakService,
personGateway: PersonGateway,
personService: PersonService,
auditService: AuditService,
) {
get("$SAK_PATH/{sakId}/personopplysninger") {
Expand All @@ -34,7 +33,7 @@ fun Route.hentPersonRoute(

require(fnr != null) { "Fant ikke fødselsnummer på sak med sakId: $sakId" }

val personopplysninger = runBlocking { personGateway.hentEnkelPerson(fnr) }.toDTO()
val personopplysninger = personService.hentEnkelPersonForFnr(fnr).toDTO()

auditService.logMedSakId(
sakId = sakId,
Expand Down
Loading