Mulighet for å innvilge flere vedtak #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hestad
reviewed
Mar 17, 2025
app/src/main/kotlin/no/nav/tiltakspenger/saksbehandling/meldekort/domene/MeldeperiodeKjeder.kt
Outdated
Show resolved
Hide resolved
ramnav990
force-pushed
the
to-behandlinger-v2
branch
from
bfbfeac to
7764730
Compare
hestad
reviewed
Mar 20, 2025
hestad
reviewed
Mar 20, 2025
.../kotlin/no/nav/tiltakspenger/saksbehandling/repository/meldekort/MeldeperiodePostgresRepo.kt
Outdated
Show resolved
Hide resolved
ramnav990
force-pushed
the
to-behandlinger-v2
branch
from
5d98ac3 to
de5895b
Compare
anders-nom
reviewed
Mar 20, 2025
app/src/main/kotlin/no/nav/tiltakspenger/saksbehandling/meldekort/domene/MeldekortBehandling.kt
Outdated
Show resolved
Hide resolved
anders-nom
reviewed
Mar 20, 2025
app/src/main/kotlin/no/nav/tiltakspenger/saksbehandling/meldekort/domene/MeldekortBehandling.kt
Outdated
Show resolved
Hide resolved
hestad
reviewed
Mar 20, 2025
app/src/main/kotlin/no/nav/tiltakspenger/saksbehandling/meldekort/domene/MeldekortBehandling.kt
Outdated
Show resolved
Hide resolved
...lin/no/nav/tiltakspenger/saksbehandling/saksbehandling/domene/behandling/SakRevurderingEx.kt
Outdated
Show resolved
Hide resolved
| rammevedtakRepo.lagre(vedtak, tx) | ||
| statistikkSakRepo.lagre(sakStatistikk, tx) | ||
| statistikkStønadRepo.lagre(stønadStatistikk, tx) | ||
| meldeperiodeRepo.lagre(førsteMeldeperiode, tx) | ||
| oppdaterteMeldekort.forEach { meldekortBehandlingRepo.oppdater(it, tx) } | ||
| meldeperioder.forEach { |
There was a problem hiding this comment.
Trodde vi hadde en metode for å sende hele lista? Men husk at det er viktig og sende/bruke tx.
There was a problem hiding this comment.
Yep, lagde den etter 😁
hestad
reviewed
Mar 20, 2025
anders-nom
reviewed
Mar 20, 2025
app/src/main/kotlin/no/nav/tiltakspenger/saksbehandling/meldekort/domene/Meldeperiode.kt
Outdated
Show resolved
Hide resolved
hestad
reviewed
Mar 20, 2025
| ADD COLUMN IF NOT EXISTS siste_dag_som_gir_rett DATE DEFAULT NULL; | ||
|
|
||
| UPDATE sak s | ||
| SET siste_dag_som_gir_rett = (SELECT MAX(m.til_og_med) |
There was a problem hiding this comment.
Lurer kanskje på om du må gjøre en kode-migrering her. Denne vil ikke ta høyde for stans. Du måtte hentet siste meldeperiode per kjede.
anders-nom
reviewed
Mar 20, 2025
app/src/main/kotlin/no/nav/tiltakspenger/saksbehandling/meldekort/domene/Meldeperiode.kt
Outdated
Show resolved
Hide resolved
hestad
reviewed
Mar 20, 2025
| TiltakMother, | ||
| SaksopplysningerMother, | ||
| BarnetilleggMother { | ||
| val saksId = SakId.random() |
There was a problem hiding this comment.
Ikke noe fan av statiske sakId, fnr og saksnummer. Vi har blant annet bare en database, som forventer at hver test har unike verdier her. (vi sletter ikke mellom testene)
There was a problem hiding this comment.
Mange steder benytter vi oss av mye av samme data uansett. Dette ville ihvertfall føre til litt cleanere test-data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.