Prodsette #1853 #1855
Merged
Prodsette #1853 #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sondre Larsen Ovrid <[email protected]>
Co-authored-by: Sondre Larsen Ovrid <[email protected]>
…rbportefolje into filtrer-gjeldende-vedtak14a
Co-authored-by: Sondre Larsen Ovrid <[email protected]>
…eilarboppfølging men inneværande oppfølgingsperiode vart starta etter lansering Co-authored-by: Sneha Desai <[email protected]>
…re sjekken sjølv i andre services osv.
…er/hierarki betre
…skal basere seg på "gjeldande" § 14 a-vedtak, ikkje "siste"
Flett inn gjeldende § 14 a-vedtak
github-actions
bot
added
the
not dependabot
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Denne PR-en fiksar ein feil i logikken for innfletting av data relatert til gjeldende § 14 a-vedtak.
Tidlegare indekserte vi siste § 14 a-vedtaket "as-is", som i mange tilfeller er feil sidan det siste vedtaket fort kan vere frå ein annan oppfølgingsperiode enn den inneverande. Det riktige er å kun indeksere data om § 14 a-vedtak dersom det er fatta innanfor noverande oppfølgingsperiode for ein gitt brukar. Det er eit unntak/edge-case: for vedtak som vart fatta før oppfølgingsperiode-konseptet blei innført (desember 2017) kan vi ikkje utan vidare forholde oss til noverande oppfølgingsperiode. Vi ender difor opp med å innføre følgande regelsett:
gjeldende § 14 a-vedtak = siste § 14 a-vedtakgjeldende § 14 a-vedtak = siste § 14 a-vedtakgjeldende § 14 a-vedtak = nullTrello ticket number and link
TC-912
Type of change
Please delete options that are not relevant.
Checklist before requesting a review