update zlib to 1.3.2 and static link zlib#562
Open
Un1q32 wants to merge 8 commits intonbcraft-org:masterfrom
Open
update zlib to 1.3.2 and static link zlib#562Un1q32 wants to merge 8 commits intonbcraft-org:masterfrom
Un1q32 wants to merge 8 commits intonbcraft-org:masterfrom
Conversation
Member
|
Given the circumstances, I'd say always static link if possible. |
BrentDaMage
reviewed
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently they fixed some RCE.
Should we always static link zlib? Some platforms where we dynamic link, like old iOS and macOS versions, have very old versions with multiple RCE vulnerabilities.