Stop overwriting appVersion with the git tag in release workflow - #21
Open
tylerpotts wants to merge 1 commit into
Open
Stop overwriting appVersion with the git tag in release workflow#21tylerpotts wants to merge 1 commit into
tylerpotts wants to merge 1 commit into
Conversation
The release workflow replaced appVersion (the Superset version, e.g. 6.1.0) with the chart's git tag (e.g. v0.4.0), so the published helm index showed the wrong app version. Keep only the chart version bump and let Chart.yaml's real appVersion flow through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release workflow's "Update Chart version" steps ran two seds on
chart/Chart.yaml: one to set the chartversionfrom the tag (correct), and one that overwroteappVersionwith the git tag itself. As a result the published helm index at https://github.com/nebari-dev/helm-repository showsAPP VERSION: v0.4.0for the latest chart instead of the actual Superset version6.1.0.Fix
Remove the
appVersionsed from both thepublish-helm-chartandsync-helm-repositoryjobs so the realappVersioninchart/Chart.yamlflows through to the packaged chart and the helm repo index.The corrected
appVersionwill show up in the index on the next release.