This repository was archived by the owner on Apr 6, 2020. It is now read-only.
Simplify reloadLocalizations method and add comments in regexp#32
Open
marchv wants to merge 9 commits intonek023:masterfrom
marchv:master
Open
Simplify reloadLocalizations method and add comments in regexp#32marchv wants to merge 9 commits intonek023:masterfrom marchv:master
marchv wants to merge 9 commits intonek023:masterfrom
marchv:master
Conversation
Author
|
This simplification seems also to fix the problem with comments mentioned by others :) |
…nt in LNPopoverContentView
… and also refactored a little bit
…uplicate name-language combos
Author
|
Hello :) Cheers! |
…ssible duplicate name-language combos" This reverts commit 9f88ae7.
…guish possible duplicate name-language combos"" This reverts commit b063b5d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi :)
I have started to look into how to support comments, which also can be edited from the plug-in. But my first iteration was a simplification of the regular expression handling, which I hope you like.
Thanks and best regards! :)