fix: allow yaml anchors

[ChristopherHX]

• GitHub Actions finally supports them

See actions/runner#1182 (comment)

[github-actions]

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ EDITORCONFIG	editorconfig-checker	2		0	0.01s
✅ REPOSITORY	gitleaks	yes		no	2.77s
✅ REPOSITORY	git_diff	yes		no	0.01s
✅ REPOSITORY	grype	yes		no	14.4s
✅ REPOSITORY	secretlint	yes		no	1.22s
✅ REPOSITORY	trivy-sbom	yes		no	0.38s
✅ REPOSITORY	trufflehog	yes		no	4.04s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.74%. Comparing base (bd4bc99) to head (5e62222).
⚠️ Report is 25 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5893      +/-   ##
==========================================
+ Coverage   74.65%   74.74%   +0.08%     
==========================================
  Files          73       73              
  Lines       11139    11193      +54     
==========================================
+ Hits         8316     8366      +50     
- Misses       2186     2190       +4     
  Partials      637      637              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ChristopherHX]

We may want to remove this if, since the parameters of success are removed (except from the schema)

Suggested change

if: success() || success('joba', 'jobb') || failure() || failure('joba', 'jobb') || always() || cancelled()

[ChristopherHX]

At the moment still broken, expressions inside anchors. EvaluateYamlNode needs updates as well to evaluate *os action expressions.

on: push
jobs:
  _:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        os:
        - &os ${{ github.event_name }}
        - *os
        - *os
    steps:
      - name: Checkout
        uses: actions/checkout@v4
      - name: Run Tests
        run: echo 'Running tests... ${{ matrix.os }}'

[ChristopherHX]

Broken as well

jobs:
  _:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        on: &matrix [push, pull_request]
    steps:
      - name: Checkout
        uses: actions/checkout@v4
      - name: Run Tests
        run: echo 'Running tests...'
on: *matrix

[programmerjake]

Suggested change

	if node.Kind == yaml.AliasNode {
	if node != nil && node.Kind == yaml.AliasNode {

to match the if above so you don't crash on nil

[programmerjake]

or maybe just return an error if nil is passed in since checkExpression a few lines down would just crash next

[ChristopherHX]

I have checked this yaml in a test

func TestNull(t *testing.T) {
	var node yaml.Node
	err := yaml.Unmarshal([]byte(`
on: push
jobs:
  job-with-condition:
    runs-on: self-hosted
    steps:
    -
`), &node)
	if !assert.NoError(t, err) {
		return
	}
	err = (&Node{
		Definition: "workflow-root-strict",
		Schema:     GetWorkflowSchema(),
	}).UnmarshalYAML(&node)
	assert.NoError(t, err)
}

Shows a non zero node passed with !null tag, by nested elements. I assume this can not crash at all.

[ChristopherHX]

After more consideration, due to yaml anchor problems across the codebase. I am going to discard this PR in favor of https://patch-diff.githubusercontent.com/raw/actions-oss/act-cli/pull/126.patch, it is better to explode yaml anchors right away that fixes a lot of other bugs documented here.

[nopeless]

would love to see a tracking issue for this @ChristopherHX if you don't mind

[ChristopherHX]

@nopeless Please subscribe to #5947