-
Notifications
You must be signed in to change notification settings - Fork 223
Add DNS oracle protocol #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
shargon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it's better to define the dns server, and make a dns query, instead of http query
We need DNS over HTTPS. |
Then it's DoH no Dns, we should rename the oracle protocol |
| CertificatePublicKey key = new() | ||
| { | ||
| Algorithm = cert.PublicKey.Oid?.FriendlyName ?? cert.PublicKey.Oid?.Value, | ||
| Encoded = Convert.ToBase64String(cert.GetPublicKey()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it's better to construct this object inside the try/catch clause, it's possible to throw CryptographicException during cert.GetPublicKey()
DoH is very commom see https://www.rfc-editor.org/rfc/rfc8484.html Can we follow rfc8484? |
Co-authored-by: Will <[email protected]>
Co-authored-by: Will <[email protected]>
- Replace application/dns-json with standard application/dns-message - Implement DNS wire format (RFC 1035) for query/response encoding - Use HTTP POST method per RFC 8484 specification - Add DNS name compression pointer support - Support user-specified authority in URI (dns://resolver/domain) - Fix CryptographicException handling in BuildPublicKey - Move Accept header to constructor - Add comprehensive unit tests for wire format handling - Add integration tests for Cloudflare, Google, and Quad9 DoH endpoints - Update documentation with RFC 8484 compliance details
|
Summary
Testing