Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Add] ApplicationEngineBase Settings, tools and FasterDb store #3810

Merged
merged 19 commits into from
Apr 12, 2025
Merged

[Add] ApplicationEngineBase Settings, tools and FasterDb store #3810

merged 19 commits into from
Apr 12, 2025

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Mar 7, 2025 •
edited
Loading

Description

Added FasterDb store and logging to ApplicationEngineBase. Also added ApplicationEngineSettings.

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit Tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cschuchardt88 cschuchardt88 added the Blocked This issue can't be worked at the moment label Mar 7, 2025
@cschuchardt88 cschuchardt88 changed the title [Add] ApplicationEngineBase Logging and FasterDb store [Add] ApplicationEngineBase Settings and FasterDb store Mar 7, 2025
@cschuchardt88 cschuchardt88 changed the title [Add] ApplicationEngineBase Settings and FasterDb store [Add] ApplicationEngineBase Settings, tools and FasterDb store Mar 7, 2025
@cschuchardt88 cschuchardt88 removed the Blocked This issue can't be worked at the moment label Mar 8, 2025
@cschuchardt88 cschuchardt88 mentioned this pull request Mar 9, 2025
Merged
15 tasks
shargon
shargon reviewed Mar 10, 2025
View reviewed changes
src/Shared/Neo.Build.Core/Storage/ByteArraySerializer.cs
{
var bytes = new byte[4];
reader.Read(bytes, 0, 4);
var size = BitConverter.ToInt32(bytes);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VarSize to save bytes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for testing nodes, We only talking about less than 1k blocks in most cases.

@Wi1l-B0t
Copy link
Contributor

Wi1l-B0t commented Mar 11, 2025 •
edited
Loading

This neo-build branch has a lot of commits.
Can you add some documents to explain the design and functionality of neo-build?

@cschuchardt88
Copy link
Member Author

This neo-build branch has a lot of commits. Can you add some documents to explain the design and functionality of neo-build?

Some has been added in the docs folder on the neo-build branch. I just been setting up basic setup of project and configurations. You're more than welcome to participate in development. Project is a SDK, debug, Testing and Development framework. One thing neo is lacking is the tools to diagnose, build and test nodes/data/contracts. The way I look at it is, this project is a rebuild of core and tries not to use neo core functionality, if you can help it. neo-build is going to have all the features neo-express has plus more. neo-express is outdated and no longer maintained.

Docs here: https://github.com/neo-project/neo/tree/neo-build/docs/neo-build

@Wi1l-B0t
Copy link
Contributor

This branch has conflicts

@cschuchardt88
Copy link
Member Author

Fixed now.

@cschuchardt88 cschuchardt88 requested a review from shargon March 23, 2025 18:34
@shargon shargon merged commit 565d3aa into neo-project:neo-build Apr 12, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@Jim8y Jim8y Jim8y approved these changes

@Wi1l-B0t Wi1l-B0t Wi1l-B0t approved these changes

Assignees

@shargon shargon

Labels
Neo Build Ready to Merge Waiting for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cschuchardt88 @Wi1l-B0t @shargon @Jim8y