-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that view interops can't be changed outside #3812
base: master
Are you sure you want to change the base?
Conversation
Please @superboyiii could you help testing this one? |
Sure |
It's compatible on mainnet. |
Require #3829 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also checked NeoGo regarding the same problem, but our DB structure is a bit simpler in that we don't have such cache for native contracts (we always perform an "honest" serialization), hence we don't have this problem.
BTW, some testing workflows are failing, is it expected?
|
I will review it |
Removed some methods, it will require a deep review for add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Description
Ensure that view interop can't be changed outside.
There are views that returns interop types related to the storage, if this are changed, it will be changed.
Complementary to #3802
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: