Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Style]: clearer style for Cache #3847

Merged
merged 4 commits into from
Mar 26, 2025

Conversation

Wi1l-B0t
Copy link
Contributor

Description

Make code style of Cache more standardized.

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Wi1l-B0t Wi1l-B0t force-pushed the style.cache-clearer branch from 7a7709f to 2e9802a Compare March 23, 2025 16:09
Comment on lines -24 to -25
protected class CacheItem
(TKey key, TValue value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have no idea why the format was like this, sort of like some c or c++ style

Jim8y
Jim8y previously approved these changes Mar 24, 2025
@Jim8y Jim8y added Minor Change Easy-to-Review a simple edit; just a few lines labels Mar 24, 2025
@shargon shargon merged commit af9371a into neo-project:master Mar 26, 2025
6 checks passed
@Wi1l-B0t Wi1l-B0t deleted the style.cache-clearer branch April 2, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy-to-Review a simple edit; just a few lines Minor Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants