Simplify result summary api #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result summary can now only be returned from `finish`, which also consumes the stream. The next_or_summary and *_items_* methods are removed. This also simplifies the API for finish, the summary no longer has to be returned as an option. Before it could have already been returned by a call to next_or_summary, which would result in a None being returned from finish. Having the API like that is also closer to APIs from the product drivers
knutwalker
force-pushed
the
simplify-result-summary-api
branch
from
bcfa321 to
eac007c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result summary can now only be returned from
finish, which also consumes the stream.The next_or_summary and items methods are removed.
This also simplifies the API for finish, the summary no longer has to be returned as an option.
Before it could have already been returned by a call to next_or_summary, which would result in a None being returned from finish.
Having the API like that is also closer to APIs from the product drivers