Adds query execution capabilities to VSCode #253

ncordon · 2024-07-29T16:59:48Z

No description provided.

Co-authored-by: Adam Cowley <[email protected]>

changeset-bot · 2024-07-29T16:59:52Z

⚠️ No Changeset found

Latest commit: bd03b98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

daveajrussell · 2024-08-01T16:15:05Z

packages/vscode-extension/src/executionService.ts

what if we moved this function to the commandHandlers module? thinking that most other commands registered in the registration service delegate to functions in the commandHandlers module

daveajrussell · 2024-08-01T16:15:47Z

packages/vscode-extension/src/webviews/resultPanel.ts

file is named resultPanel, but class is named ResultWindow - should we rename one to match the other?

daveajrussell · 2024-08-01T16:17:10Z

packages/vscode-extension/src/webviews/resultPanel.ts

+
+export function getErrorContent(err: Error): string {
+  return `
+    <details class="error">
+      <summary style="color:red">Error: ${err.message}</summary>
+      <pre>${err.stack}</pre>
+    </details>
+  `;
+}


I can't see any usages of this function

Suggested change

export function getErrorContent(err: Error): string {

return `

<details class="error">

<summary style="color:red">Error: ${err.message}</summary>

<pre>${err.stack}</pre>

</details>

`;

}

daveajrussell · 2024-08-01T16:18:52Z

packages/vscode-extension/src/contextService.ts

@@ -47,6 +48,7 @@ type SchemaPoller = {
 let _context: ExtensionContext | undefined;
 let _languageClient: LanguageClient | undefined;
 let _schemaPoller: SchemaPoller | undefined;
+let _queryRunner: CypherRunner | undefined;


Suggested change

let _queryRunner: CypherRunner | undefined;

let _cypherRunner: CypherRunner | undefined;

should we call this _cypherRunner to match its type name or vice versa?

daveajrussell · 2024-08-01T16:33:10Z

packages/vscode-extension/src/webviews/resultPanel.ts

+): string {
+  const nonce = getNonce();
+
+  return `


I had an idea to create a reusable webview template engine.. I've created a draft here #255

The idea is we create a common html template and stylesheets so that all webviews use the same "base", but allows for customising scripts and stylesheets

I don't know if this is premature optimisation, or if it's entirely worthwhile (wondering how many webviews we're going to create), but it tidies a few things up, I think

That seems sensible to me. What order do you want to merge them? This pr first, then the one refactoring the html template?

shall we merge mine later? 👍

daveajrussell · 2024-08-01T16:35:38Z

packages/vscode-extension/src/webviews/resultPanel.ts

+ * @return {Record<string, any>}
+ */
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+export function toNativeTypes(properties: Record<string, any>) {


I wonder if these functions might be better served in a util-like module? they don't seem strictly related to the markup of a webview

ncordon · 2024-08-09T09:47:14Z

packages/react-codemirror-playground/package.json

@@ -42,6 +42,7 @@
    "postcss": "^8.4.23",
    "tailwindcss": "^3.3.1",
    "typescript": "^4.9.5",
-    "vite": "^4.2.0"
+    "vite": "^4.2.0",
+    "esbuild": "^0.19.4"


Without this, I struggle to build the project sometimes in osx:

@neo4j-cypher/react-codemirror-playground:build: failed to load config from /Users/ncordon/neo4j/intellisense/cypher-lsp/packages/react-codemirror-playground/vite.config.ts @neo4j-cypher/react-codemirror-playground:build: error during build: @neo4j-cypher/react-codemirror-playground:build: Error: The package "@esbuild/darwin-x64" could not be found, and is needed by esbuild. @neo4j-cypher/react-codemirror-playground:build: @neo4j-cypher/react-codemirror-playground:build: If you are installing esbuild with npm, make sure that you don't specify the @neo4j-cypher/react-codemirror-playground:build: "--no-optional" or "--omit=optional" flags. The "optionalDependencies" feature @neo4j-cypher/react-codemirror-playground:build: of "package.json" is used by esbuild to install the correct binary executable @neo4j-cypher/react-codemirror-playground:build: for your current platform. @neo4j-cypher/react-codemirror-playground:build: at generateBinPath (/Users/ncordon/neo4j/intellisense/cypher-lsp/packages/react-codemirror-playground/node_modules/esbuild/lib/main.js:1899:15) @neo4j-cypher/react-codemirror-playground:build: at esbuildCommandAndArgs (/Users/ncordon/neo4j/intellisense/cypher-lsp/packages/react-codemirror-playground/node_modules/esbuild/lib/main.js:1969:33) @neo4j-cypher/react-codemirror-playground:build: at ensureServiceIsRunning (/Users/ncordon/neo4j/intellisense/cypher-lsp/packages/react-codemirror-playground/node_modules/esbuild/lib/main.js:2133:25) @neo4j-cypher/react-codemirror-playground:build: at build (/Users/ncordon/neo4j/intellisense/cypher-lsp/packages/react-codemirror-playground/node_modules/esbuild/lib/main.js:2025:26) @neo4j-cypher/react-codemirror-playground:build: at bundleConfigFile (file:///Users/ncordon/neo4j/intellisense/cypher-lsp/packages/react-codemirror-playground/node_modules/vite/dist/node/chunks/dep-41cf5ffd.js:66209:26) @neo4j-cypher/react-codemirror-playground:build: at loadConfigFromFile (file:///Users/ncordon/neo4j/intellisense/cypher-lsp/packages/react-codemirror-playground/node_modules/vite/dist/node/chunks/dep-41cf5ffd.js:66185:31) @neo4j-cypher/react-codemirror-playground:build: at resolveConfig (file:///Users/ncordon/neo4j/intellisense/cypher-lsp/packages/react-codemirror-playground/node_modules/vite/dist/node/chunks/dep-41cf5ffd.js:65782:34) @neo4j-cypher/react-codemirror-playground:build: at build (file:///Users/ncordon/neo4j/intellisense/cypher-lsp/packages/react-codemirror-playground/node_modules/vite/dist/node/chunks/dep-41cf5ffd.js:47926:26) @neo4j-cypher/react-codemirror-playground:build: at CAC.<anonymous> (file:///Users/ncordon/neo4j/intellisense/cypher-lsp/packages/react-codemirror-playground/node_modules/vite/dist/node/cli.js:842:15) @neo4j-cypher/react-codemirror-playground:build: npm ERR! Lifecycle script `build` failed with error: @neo4j-cypher/react-codemirror-playground:build: npm ERR! Error: command failed @neo4j-cypher/react-codemirror-playground:build: npm ERR! in workspace: @neo4j-cypher/[email protected] @neo4j-cypher/react-codemirror-playground:build: npm ERR! at location: /Users/ncordon/neo4j/intellisense/cypher-lsp/packages/react-codemir

daveajrussell

Looks great, working as expected 👍

ncordon and others added 2 commits July 29, 2024 18:37

Adds ndl packages

359a2fc

Adds query-execution capabilities

e7c3d44

Co-authored-by: Adam Cowley <[email protected]>

Cleans up

fe68d76

ncordon requested a review from daveajrussell July 29, 2024 17:14

Base automatically changed from adds-ndl to main July 30, 2024 08:19

Merge branch 'main' into vscode-query-execution

eb7065b

daveajrussell reviewed Aug 6, 2024

View reviewed changes

ncordon and others added 3 commits August 9, 2024 11:15

Addresses review comments

4ca443c

Merge branch 'main' into vscode-query-execution

2fc4949

Minor nit

bd03b98

ncordon force-pushed the vscode-query-execution branch from 3591496 to bd03b98 Compare August 9, 2024 09:37

ncordon commented Aug 9, 2024

View reviewed changes

ncordon requested a review from daveajrussell August 9, 2024 13:48

daveajrussell approved these changes Aug 9, 2024

View reviewed changes

ncordon mentioned this pull request Aug 9, 2024

Adds a webview template engine for easily creating webviews #255

Closed

ncordon merged commit aa69a2e into main Aug 9, 2024
4 checks passed

ncordon deleted the vscode-query-execution branch August 9, 2024 14:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds query execution capabilities to VSCode #253

Adds query execution capabilities to VSCode #253

ncordon commented Jul 29, 2024

changeset-bot bot commented Jul 29, 2024 •

edited

Loading

daveajrussell Aug 1, 2024

daveajrussell Aug 1, 2024

daveajrussell Aug 1, 2024

daveajrussell Aug 1, 2024

daveajrussell Aug 1, 2024

ncordon Aug 9, 2024

daveajrussell Aug 9, 2024

daveajrussell Aug 1, 2024

ncordon Aug 9, 2024

daveajrussell left a comment

	let _queryRunner: CypherRunner \| undefined;
	let _cypherRunner: CypherRunner \| undefined;

Adds query execution capabilities to VSCode #253

Adds query execution capabilities to VSCode #253

Conversation

ncordon commented Jul 29, 2024

changeset-bot bot commented Jul 29, 2024 • edited Loading

⚠️ No Changeset found

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daveajrussell left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Jul 29, 2024 •

edited

Loading