Retry idempotent queries using builtin mechanism in neo4j driver #868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for neo4j-graph-data-science-client canceled.
|
FlorentinD
force-pushed
the
run-cypher-retryability
branch
from
435274c to
3781b2d
Compare
✅ Deploy Preview for neo4j-graph-data-science-client canceled.
|
FlorentinD
changed the title
FlorentinD
commented
Jun 3, 2025
FlorentinD
commented
Jun 3, 2025
FlorentinD
commented
Jun 3, 2025
FlorentinD
force-pushed
the
run-cypher-retryability
branch
from
3781b2d to
4d2ac35
Compare
DarthMax
approved these changes
Jun 5, 2025
Comment on lines
+261
to
+262
| routing = neo4j.RoutingControl.WRITE if "write" in endpoint else neo4j.RoutingControl.READ | ||
| return self.run_retryable_cypher(query, params, database, custom_error, routing=routing) |
There was a problem hiding this comment.
Will this ever be a safe combination. Our write are not always idempotent.
There was a problem hiding this comment.
the main case was gds.arrow.write.v3
Maybe should rather have it explicit in for the write protocol case
There was a problem hiding this comment.
okay its already explicit as before the caller needs to have passed retryable=True explicitly
There was a problem hiding this comment.
Maybe instead of doing the string matching we could pass in the RoutingControl from the caller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.