[1.21.11] Add neoforge API for the ManagementApi#2647
Open
Minecraftschurli wants to merge 17 commits intoneoforged:1.21.11from
Open
[1.21.11] Add neoforge API for the ManagementApi#2647Minecraftschurli wants to merge 17 commits intoneoforged:1.21.11from
Minecraftschurli wants to merge 17 commits intoneoforged:1.21.11from
Conversation
|
Matyrobbrt
requested changes
Sep 21, 2025
Member
Matyrobbrt
left a comment
Matyrobbrt
left a comment
There was a problem hiding this comment.
I don't think we need to push this "service" complexity onto modders. I would rather add a dedicated server parameter to the MinecraftApi, and not add this service map and additional api and implementation complexity. I'm not sure what this abstraction achieves, if anything.
It could allow one to unit test easier, but as it stands you'd already need to mock several services to be able to construct one, to the point where mocking the dedicated server or starting up an ephemeral one is easier. And even then, I'm not sure it is a benefit that is valuable enough to deserve the complexity cost. Not to mention that it would not be particularly hard for a mod to adopt this design for itself.
Minecraftschurli
force-pushed
the
feature/jsonrpc-api
branch
from
9594771 to
d67a948
Compare
Minecraftschurli
force-pushed
the
feature/jsonrpc-api
branch
from
d67a948 to
dcb7d6d
Compare
Matyrobbrt
requested changes
Sep 28, 2025
Minecraftschurli
force-pushed
the
feature/jsonrpc-api
branch
from
dcb7d6d to
705b419
Compare
Minecraftschurli
force-pushed
the
feature/jsonrpc-api
branch
from
57dffc9 to
f51b207
Compare
Matyrobbrt
requested changes
Oct 6, 2025
Minecraftschurli
changed the title
Minecraftschurli
added
1.21.10
Minecraftschurli
force-pushed
the
feature/jsonrpc-api
branch
from
f51b207 to
0bdb927
Compare
Minecraftschurli
force-pushed
the
feature/jsonrpc-api
branch
from
0bdb927 to
ec6675a
Compare
Matyrobbrt
requested changes
Oct 13, 2025
Minecraftschurli
force-pushed
the
feature/jsonrpc-api
branch
2 times, most recently
from
f6dff83 to
07193b0
Compare
Matyrobbrt
requested changes
Oct 29, 2025
Minecraftschurli
force-pushed
the
feature/jsonrpc-api
branch
from
924bf65 to
bf8d2a5
Compare
Minecraftschurli
changed the title
Minecraftschurli
added
1.21.11
…nrpc codecs registry aware
Minecraftschurli
force-pushed
the
feature/jsonrpc-api
branch
from
c7425f1 to
73fe808
Compare
sciwhiz12
added
needs rebase
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
DedicatedServerandJsonRpcLoggerto theMinecraftApithat is passed to handler functions for Json-RPC methods and makes the serializing and deserializing of parameters and return values of Json-RPC methods registry aware. In addition it adds an event to registerSchemaComponentinstances used in the Json-RPC schema.