Add a feature to use Display as Decimal's Debug output#48
Open
shuoli84 wants to merge 2 commits intoneogenie:masterfrom
Open
Add a feature to use Display as Decimal's Debug output#48shuoli84 wants to merge 2 commits intoneogenie:masterfrom
shuoli84 wants to merge 2 commits intoneogenie:masterfrom
Conversation
Owner
|
Thank you for the feedback and participation in the project! I don't think it's worth using the features’ mechanism for these purposes, as it will create issues during use of The first thing that comes to mind is to use compile-time variables, where some display parameters are already configured. Also, for these purposes, we can use Debug ( |
Author
|
Yes, you are right. the feature flag is not pure additive, which makes it tricky. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a user, the default Debug impl is hard to reason, so I add a feature to let client switch to human friendlier debug output.