Open
Conversation
Signed-off-by: Yury Katkov <ykatkov@yandex.ru>
Signed-off-by: Yury Katkov <ykatkov@yandex.ru>
Signed-off-by: Yury Katkov <ykatkov@yandex.ru>
Signed-off-by: Yury Katkov <ykatkov@yandex.ru>
Signed-off-by: Yury Katkov <ykatkov@yandex.ru>
Signed-off-by: Yury Katkov <ykatkov@yandex.ru>
Signed-off-by: Yury Katkov <ykatkov@yandex.ru>
vectorFill replaced by std::fill_n dataCopy replaced by std::copy Signed-off-by: Yury Katkov <ykatkov@yandex.ru>
Signed-off-by: Yury Katkov <ykatkov@yandex.ru>
Extract common code for simple math primitives. Signed-off-by: Yury Katkov <ykatkov@yandex.ru>
Signed-off-by: Yury Katkov <ykatkov@yandex.ru>
Signed-off-by: Yury Katkov <ykatkov@yandex.ru>
Signed-off-by: Yury Katkov <ykatkov@yandex.ru>
lordnn
reviewed
Feb 12, 2022
NeoMathEngine/src/CPU/x86/CpuX86.h
Outdated
|
|
||
| sseSize -= 4; | ||
| if( vectorSize > 0 ) { | ||
| memcpy( dst, src, vectorSize * sizeof( T ) ); |
Contributor
There was a problem hiding this comment.
Какая-то непоследовательность. Если std::fill_n, тогда std::copy_n, зачем memcpy?
Contributor
Author
There was a problem hiding this comment.
Да, согласен. copy_n будет лучше смотреться
Signed-off-by: Yury Katkov <ykatkov@yandex.ru>
lordnn
reviewed
Feb 14, 2022
| } | ||
| genInst.lock.unlock(); | ||
| return genInst.gen.getCode(); | ||
| return reinterpret_cast<void*>( const_cast<uint8_t*>( genInst.gen.getCode() ) ); |
Contributor
There was a problem hiding this comment.
Хватило бы static_cast, а reinterpret_cast - перебор.
Fix PR comment. Signed-off-by: Yury Katkov <ykatkov@yandex.ru>
Signed-off-by: Yury Katkov <ykatkov@yandex.ru>
Signed-off-by: Yury Katkov <ykatkov@yandex.ru>
Signed-off-by: Yury Katkov <ykatkov@yandex.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.