WIP Upgrade package to rector/rector 1.0 #59
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kdambekalns
reviewed
May 14, 2024
There was a problem hiding this comment.
@dlubitz Could you explain a bit about the changes still needed?
- What did thet
NodesToAddCollectordo? - Those lines you simply commented out, what needs to be done?
- In some places you added
// return NodeTraverser::REMOVE_NODE;– while in other places you just used it as a solution?
Other than that 21 of 43 fiels changed look good to me by reading. 😇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently blocked due to the fact, that rector has removed the functionality for using a custom file processor.
See: rectorphp/rector-src#4808
Other open task:
$rectorConfig->services()withRectorConfig::configure()>registerService()$this->removeNode()