Skip to content

fix(eslint): Find closest ESLint directory to avoid version mismatch #3686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

estacioneto
Copy link
Contributor

Fixes #3685, where projects with different ESLint versions incorrectly used the farthest version instead of the closest.

@estacioneto estacioneto requested a review from glepnir as a code owner April 3, 2025 14:18
@justinmk justinmk merged commit 9383556 into neovim:master Apr 4, 2025
10 of 11 checks passed
@MrRoiz
Copy link

MrRoiz commented Apr 4, 2025

Not sure if this is the issue but after updating nvim-lspconfig my eslint lsp does not shows any diagnosis 🤔

EDIT: Yep, just reverted this commit in my config and my eslint lsp worked again.

@justinmk
Copy link
Member

justinmk commented Apr 5, 2025

reverted : #3689

@estacioneto
Copy link
Contributor Author

Interesting @MrRoiz... Can you share the :LspLog so I can figure out what made it not show the diagnosis? I'm curious on how it broke your setup

TheRealLorenz pushed a commit to TheRealLorenz/nvim-lspconfig that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESLint: Possible issue with root directory when working with different ESLint versions
3 participants