chore: enhance test setup, improve compatibility, and fix security issues #918
Conversation
Tekvology
commented
Feb 14, 2025
Tekvology
commented
- Removed coveralls dependency.
- Added npm-run-all2 for better script management.
- Split build scripts into smaller, modular tasks.
- Improved cross-platform compatibility for script execution.
- Implemented security overrides for dependencies.
- Added cross-env to ensure setup:test script runs consistently across environments.
- Installed sqlite3 to speed up testing.
- Updated ORM configuration to use an inbuilt SQLite database for improved test performance.
- Fixed test cases to align with the new setup.
- Successfully ran test coverage – all tests passed.
- Removed coveralls dependency - Added npm-run-all2 for better script management - Split build scripts into smaller, focused tasks - Improved cross-platform compatibility - Added security overrides for dependencies
Added cross-env for executing the setup:test script across different environments. Installed sqlite3 for faster testing support. Replaced coverageall with npm-run-all2 to address security issues. Updated scripts to support execution on both Linux and Windows. Modified base ORM config to use an inbuilt SQLite database for faster testing. Fixed test cases to align with the new setup. Ran test coverage – all tests passed successfully.
|
Test Results
Clover Output |
| "name": "nestjs-typeorm-paginate", | ||
| "name": "tekvo-nest-typeorm-paginate", | ||
| "author": { | ||
| "name": "Ashleigh Simonelli", | ||
| "email": "ashleighsimonelli@gmail.com", | ||
| "url": "http://ashleighsimonelli.co.uk" | ||
| "name": "Elvin Baghele", | ||
| "email": "baghele.elvin@gmail.com", | ||
| "url": "https://github.com/elvinbaghele" |
There was a problem hiding this comment.
Very unnecessary, can you revent these changes?
There was a problem hiding this comment.
We had to use this package, but since updates were missing, I created another package. However, I didn't realize the changes also got reflected in this PR. I will push a new commit on this one to revent
| "url": "https://github.com/nestjsx/nestjs-typeorm-paginate" | ||
| "url": "https://github.com/Tekvology/nestjs-typeorm-paginate" |
There was a problem hiding this comment.
We had to use this package, but since updates were missing, I created another package. However, I didn't realize the changes also got reflected in this PR. I will push a new commit on this one to revent
| <img src="https://github.com/nestjsx/nestjs-typeorm-paginate/workflows/Tests/badge.svg"/> | ||
| <a href="https://www.npmjs.com/package/nestjs-typeorm-paginate"><img src="https://img.shields.io/npm/v/nestjs-typeorm-paginate.svg"/></a> | ||
| <a href='https://coveralls.io/github/nestjsx/nestjs-typeorm-paginate?branch=master'><img src='https://coveralls.io/repos/github/nestjsx/nestjs-typeorm-paginate/badge.svg?branch=master' alt='Coverage Status' /></a> | ||
| <img src="https://github.com/nestjsx/tekvo-nest-typeorm-paginate/workflows/Tests/badge.svg"/> | ||
| <a href="https://www.npmjs.com/package/tekvo-nest-typeorm-paginate"><img src="https://img.shields.io/npm/v/tekvo-nest-typeorm-paginate.svg"/></a> | ||
| <a href='https://coveralls.io/github/nestjsx/tekvo-nest-typeorm-paginate?branch=master'><img src='https://coveralls.io/repos/github/nestjsx/tekvo-nest-typeorm-paginate/badge.svg?branch=master' alt='Coverage Status' /></a> | ||
| <img src="https://camo.githubusercontent.com/a34cfbf37ba6848362bf2bee0f3915c2e38b1cc1/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f5052732d77656c636f6d652d627269676874677265656e2e7376673f7374796c653d666c61742d737175617265" /> | ||
| <a href="https://github.com/juliandavidmr/awesome-nestjs#components--libraries"><img src="https://raw.githubusercontent.com/nestjsx/crud/master/img/awesome-nest.svg?sanitize=true" alt="Awesome Nest" /></a> | ||
| <a href="https://github.com/nestjs/nest"><img src="https://raw.githubusercontent.com/nestjsx/crud/master/img/nest-powered.svg?sanitize=true" alt="Nest Powered" /></a> | ||
| <a href="https://packagequality.com/#?package=nestjs-typeorm-paginate"><img src="https://packagequality.com/shield/nestjs-typeorm-paginate.svg" /></a> | ||
| <a href="https://packagequality.com/#?package=tekvo-nest-typeorm-paginate"><img src="https://packagequality.com/shield/tekvo-nest-typeorm-paginate.svg" /></a> | ||
| <a href="https://www.npmjs.com/org/nestjsx"> | ||
| <img src="https://img.shields.io/npm/dt/nestjs-typeorm-paginate.svg" alt="npm downloads" /> | ||
| <img src="https://img.shields.io/npm/dt/tekvo-nest-typeorm-paginate.svg" alt="npm downloads" /> | ||
| </a> | ||
| </p> | ||
|
|
||
| <h1 align="center">Nestjs Typeorm paginate</h1> | ||
| <h1 align="center">Tekvo - Nestjs Typeorm paginate</h1> |
There was a problem hiding this comment.
Not necessary to change the package name and links
There was a problem hiding this comment.
We had to use this package, but since updates were missing, I created another package. However, I didn't realize the changes also got reflected in this PR. I will push a new commit on this one to revent
| $ yarn add nestjs-typeorm-paginate | ||
| $ yarn add tekvo-nest-typeorm-paginate | ||
| ``` | ||
| or | ||
| ```bash | ||
| $ npm i nestjs-typeorm-paginate | ||
| $ npm i tekvo-nest-typeorm-paginate | ||
| ``` | ||
|
|
||
| > If you're using typeorm^0.2.6 please use nestjs-typeorm-paginate^3.2.0 | ||
| > For typeorm^0.3.0 please use nestjs-typeorm-paginate^4.0.0 | ||
| > If you're using typeorm^0.2.6 please use tekvo-nest-typeorm-paginate^3.2.0 | ||
| > For typeorm^0.3.0 please use tekvo-nest-typeorm-paginate^4.0.4 |
There was a problem hiding this comment.
unnecessary to change package links and name
There was a problem hiding this comment.
We had to use this package, but since updates were missing, I created another package. However, I didn't realize the changes also got reflected in this PR. I will push a new commit on this one to revent
| @@ -94,7 +94,7 @@ export class CatService { | |||
| import { Controller, DefaultValuePipe, Get, ParseIntPipe, Query } from '@nestjs/common'; | |||
| import { CatService } from './cat.service'; | |||
| import { CatEntity } from './cat.entity'; | |||
| import { Pagination } from 'nestjs-typeorm-paginate'; | |||
There was a problem hiding this comment.
We had to use this package, but since updates were missing, I created another package. However, I didn't realize the changes also got reflected in this PR. I will push a new commit on this one to revent
| Copyright (c) 2019 Ashleigh Simonelli | ||
| Copyright (c) 2025 Elvin Baghele |
There was a problem hiding this comment.
We had to use this package, but since updates were missing, I created another package. However, I didn't realize the changes also got reflected in this PR. I will push a new commit on this one to revent
| } from 'nestjs-typeorm-paginate'; | ||
| } from 'tekvo-nest-typeorm-paginate'; |
There was a problem hiding this comment.
We had to use this package, but since updates were missing, I created another package. However, I didn't realize the changes also got reflected in this PR. I will push a new commit on this one to revent
| "name": "nestjs-typeorm-paginate", | ||
| "name": "tekvo-nest-typeorm-paginate", | ||
| "author": { | ||
| "name": "Ashleigh Simonelli", | ||
| "email": "ashleighsimonelli@gmail.com", | ||
| "url": "http://ashleighsimonelli.co.uk" | ||
| "name": "Elvin Baghele", | ||
| "email": "baghele.elvin@gmail.com", | ||
| "url": "https://github.com/elvinbaghele" |
There was a problem hiding this comment.
We had to use this package, but since updates were missing, I created another package. However, I didn't realize the changes also got reflected in this PR. I will push a new commit on this one to revent
| "url": "https://github.com/nestjsx/nestjs-typeorm-paginate" | ||
| "url": "https://github.com/Tekvology/nestjs-typeorm-paginate" |
There was a problem hiding this comment.
We had to use this package, but since updates were missing, I created another package. However, I didn't realize the changes also got reflected in this PR. I will push a new commit on this one to revent
