Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[management] Refactor routes to use store methods #2928

Open
wants to merge 151 commits into
base: main
Choose a base branch
from
Open

[management] Refactor routes to use store methods #2928

wants to merge 151 commits into from

Conversation

bcmmbaga
Copy link
Contributor

Describe your changes

Remove calls to get and save whole account in routes operations.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

bcmmbaga added 30 commits November 8, 2024 00:31
@bcmmbaga
Refactor setup key handling to use store methods
389c961 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
add lock to get account groups
78044c2 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
add check for regular user
1a5f3c6 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
get only required groups for auto-group validation
931521d 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
add account lock and return auto groups map on validation
f8b5eed 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
refactor account peers update
106fc75 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Refactor groups to use store methods
0a70e4c 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
refactor GetGroupByID and add NewGroupNotFoundError
8126d95 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
fix tests
ac05f69 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Merge branch 'feature/get-account-refactoring' into setupkey-get-acco…
40af1a5 
…unt-refactoring

# Conflicts:
#	management/server/sql_store.go
@bcmmbaga
Merge branch 'setupkey-get-account-refactoring' into groups-get-accou…
d58cf50 
…nt-refactoring

# Conflicts:
#	management/server/sql_store.go
@bcmmbaga
Add AddPeer and RemovePeer methods to Group struct
7100be8 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Preserve store engine in SqlStore transactions
6dc185e 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Run groups ops in transaction
bdeb95c 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
fix missing group removed from setup key activity
3ed8b9c 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Merge branch 'setupkey-get-account-refactoring' into groups-get-accou…
cc04aef 
…nt-refactoring
@bcmmbaga
fix merge
871500c 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Refactor posture checks to remove get and save account
174e07f 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
fix refactor
d54b696 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
fix tests
601d429 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Merge branch 'main' into groups-get-account-refactoring
010a8bf 
# Conflicts:
#	management/server/group.go
#	management/server/group/group.go
#	management/server/setupkey.go
#	management/server/sql_store.go
#	management/server/status/error.go
#	management/server/store.go
@bcmmbaga
fix merge
664d138 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
fix sonar
ab00c41 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Change setup key log level to debug for missing group
113c21b 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Retrieve modified peers once for group events
d23b5c8 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Merge branch 'groups-get-account-refactoring' into policy-get-account…
ffce48c 
…-refactoring
@bcmmbaga
Refactor policy get and save account to use store methods
0c0fd38 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Fix tests
2d7f08c 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Add tests
2806d73 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Merge branch 'groups-get-account-refactoring' into posturechecks-get-…
00023bf 
…account-refactoring
pascal-fischer and others added 28 commits January 14, 2025 21:28
@pascal-fischer
update timeouts
b1e8ed8
@bcmmbaga
Refactor ToGroupsInfo to process slices of groups
b15ee5c 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Merge remote-tracking branch 'origin/peers-get-account-refactoring' i…
7baef8c 
…nto peers-get-account-refactoring
@pascal-fischer
update expectations
30b023d
@pascal-fischer
Merge remote-tracking branch 'origin/peers-get-account-refactoring' i…
7241a16 
…nto peers-get-account-refactoring
@pascal-fischer
update expectations
167c80d
@pascal-fischer
update expectations
e27db94
@bcmmbaga
Bump integrations version
6a81ca2 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Refactor GetValidatedPeers
2fb399a 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Fix tests
22798ad 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
go mod tidy
6367fe4 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Use peers and groups map for peers validation
4afaabb 
Signed-off-by: bcmmbaga <[email protected]>
@pascal-fischer
remove mysql from api benchmark tests
aeb6e53
@bcmmbaga
Merge branch 'peers-get-account-refactoring' into users-get-account-r…
a72a331 
…efactoring

# Conflicts:
#	management/server/account.go
#	management/server/http/middleware/auth_middleware.go
#	management/server/http/middleware/auth_middleware_test.go
#	management/server/mock_server/account_mock.go
#	management/server/peer_test.go
#	management/server/status/error.go
#	management/server/store/sql_store.go
#	management/server/store/sql_store_test.go
#	management/server/store/store.go
#	management/server/user.go
@bcmmbaga
Fix merge
7124cf5 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Merge branch 'peers-get-account-refactoring' into users-get-account-r…
5c69b46 
…efactoring
@bcmmbaga
Fix blocked db calls on user auto groups update
c01da7d 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Fix tests
5b6871a 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
update expectations
d3d6967 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
update expectations
a40ce6d 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Skip user check for system initiated peer deletion
30ae3aa 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Remove context in db calls
d962f7f 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
update expectations
086fe69 
Signed-off-by: bcmmbaga <[email protected]>
@pascal-fischer
[management] Improve group peer/resource counting (#3192)
97ff9a3
@bcmmbaga
Merge branch 'peers-get-account-refactoring' into users-get-account-r…
b978556 
…efactoring
@bcmmbaga
Fix sonar
62599c0 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Merge branch 'users-get-account-refactoring' into routes-get-account-…
c52e4f9 
…refactoring

# Conflicts:
#	management/server/group.go
#	management/server/route.go
#	route/route.go
@bcmmbaga
Fix merge
397c2a7 
Signed-off-by: bcmmbaga <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 17, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Base automatically changed from users-get-account-refactoring to main February 17, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcmmbaga @pascal-fischer