Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates NetBox to v3.6 for testing #160

Closed
wants to merge 1 commit into from

Conversation

Cormoran96
Copy link

@Cormoran96 Cormoran96 commented Oct 10, 2023

Pull Request

Related Issue

fix issue #159

New Behavior

Update NetBox version in Plugin

Contrast to Current Behavior

...

Discussion: Benefits and Drawbacks

...

Changes to the Documentation

...

Proposed Release Note Entry

...

Double Check

  • I have explained my PR according to the information in the comments
    or in a linked issue.
  • My PR targets the dev branch.

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

@jsenecal
Copy link
Collaborator

This is missing:

  • the actual changes to the plugin configuration.
  • Changes to devcontainer due to netbox base image bumped to ubuntu:23.04 (this requires many changes due to the base image now having a ubuntu user with uid 1000)

@ryanmerolle
Copy link
Collaborator

@jsenecal is correct. This just updates the development container.

@Cormoran96 Cormoran96 deleted the patch-1 branch October 14, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants