Skip to content

fix: fix errors with harmonizing values #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

fix: fix errors with harmonizing values #76

merged 1 commit into from
Apr 10, 2025

Conversation

ltucker
Copy link
Contributor

@ltucker ltucker commented Apr 10, 2025 •
edited
Loading

  • fixes some issues with harmonizing prior values handling of wrong value types.
  • best effort to report a somewhat useful failure vs 500 in some cases where NetBox is not producing ValidationErrors.
  • use object type in applier (like differ) error structures / avoid issues with renumbered change set lists in ui
  • add some repro test cases

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2237 2066 92% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
netbox_diode_plugin/api/applier.py 91% 🟢
netbox_diode_plugin/api/differ.py 93% 🟢
netbox_diode_plugin/api/transformer.py 87% 🟢
netbox_diode_plugin/tests/test_api_apply_change_set.py 99% 🟢
netbox_diode_plugin/tests/test_api_diff_and_apply.py 100% 🟢
TOTAL 94% 🟢

updated for commit: 4fa6c7b by action🐍

mfiedorowicz
mfiedorowicz approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ltucker ltucker merged commit a8019f9 into feat-diode-data-plugin Apr 10, 2025
3 checks passed
@ltucker ltucker deleted the fix_harmonize branch April 10, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfiedorowicz mfiedorowicz mfiedorowicz approved these changes

@leoparente leoparente Awaiting requested review from leoparente

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltucker @mfiedorowicz