fix: special cases for ip network defaulting #81
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ip address fields and ip network fields have special defaulting in place that makes them appear to differ.
eg if
192.168.1.1
is specified in an ip address field, it will be stored (and the prior value will appear as)192.168.1.1/32
this add some special handling to use the defaulted network when comparing.secondarily, this uses special matchers for ip address that ignore the mask given on the address. This is the actual uniqueness check that is performed during the model validation.
this also resolves an issue rendering the prior state of an ipaddress which cannot directly be json serialized since it is sent back as an instance of netddr.IPNetwork