-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add a cli utility for managing clients #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go test coverage
Total coverage: 51.0% |
fe94e74
to
4725890
Compare
…ra (not run by default)
ltucker
commented
May 2, 2025
ltucker
commented
May 2, 2025
mfiedorowicz
reviewed
May 3, 2025
Co-authored-by: Michal Fiedorowicz <[email protected]>
Co-authored-by: Michal Fiedorowicz <[email protected]>
mfiedorowicz
reviewed
May 5, 2025
mfiedorowicz
approved these changes
May 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from comments on Dockerfile-build.auth
and auth client manager instantiation, works as expected, thank you!
Co-authored-by: Michal Fiedorowicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a utility for managing auth clients via cli
This pull request introduces a new utility,
auth_manage
, for managing OAuth2 clients in thediode-server
project. It includes updates to the build process, Docker configuration, and documentation, as well as the addition of new Go modules and functionality to support this feature. Below are the most important changes grouped by theme:Build and Deployment Updates:
Makefile
to includeauth_manage
as a utility, adding corresponding build and Docker targets ($(BUILD_UTILITIES)
anddocker-compose-dev-auth-manage
) for seamless integration into the build pipeline. [1] [2] [3]Dockerfile-build.auth
andDockerfile.auth
to build and include theauth_manage
binary in the Docker images. [1] [2] [3]New Utility Implementation:
auth_manage
CLI utility incmd/auth_manage/main.go
to allow the creation, retrieval, listing, and deletion of OAuth2 clients.dev-auth-manage.sh
, to simplify running theauth_manage
utility in a development environment.OAuth2 Client Management:
ClientManager
interface and its implementation using Hydra inauth/manage.go
andauth/manage_hydra.go
, enabling management of OAuth2 clients (create, retrieve, delete, and list). [1] [2]Documentation:
README.md
to include detailed instructions for provisioning and managing agent credentials using theauth_manage
utility, with examples for creating, retrieving, listing, and deleting clients.Dependency Updates:
github.com/ory/hydra-client-go/v2
module togo.mod
to support communication with the Hydra OAuth2 server.