Skip to content

[NAE-2060] Merge 6.2.10, 6.4.2 into 6.5.0#439

Open
SamuelPalaj wants to merge 112 commits into
release/6.5.0from
NAE-2060
Open

[NAE-2060] Merge 6.2.10, 6.4.2 into 6.5.0#439
SamuelPalaj wants to merge 112 commits into
release/6.5.0from
NAE-2060

Conversation

@SamuelPalaj
Copy link
Copy Markdown
Contributor

@SamuelPalaj SamuelPalaj commented May 11, 2026

Description

merge of versions 6.2.10 and 6.4.2 into 6.5.0

Implements NAE-2060

How Has Been This Tested?

Automated tests for version 6.5.0 were run on this branch

Test Configuration

Name Tested on
OS windows 11
Runtime java 11
Dependency Manager Maven 3.9.9
Framework version Spring Boot 2.7.18
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @...
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

Kovy95 and others added 30 commits January 9, 2025 14:53
- add property to component on dashboard
…Count error

- ElasticCaseService, ElasticViewPermissionService: refactored queries to use termsQuery and filter, reducing clause count.
- pom.xml: updated spring-session to spring-session-core.
…Count error

- ElasticCaseService: incorporation of reminders from PR
[NAE-2053] Optimize ElasticCaseService queries to eliminate maxClauseCount error
[NAE-2031] Dashboard bug fix
- update CHANGELOG.md
- update changelog and version
- update release date in changelog
- implement exporting cases from case view
- added ExportController,  XlsExportService, XlsExportConfiguration, XlsExportDateUtils
- added attribute allow export to preference_item and MenuItemBody
- extend IElasticCaseService with existing method to avoid code duplication
- add simple test
- resolve comments
- add documentation and validations for xls export properties
- update error messages
- update controller mapping
- update bean initialization in XlsExportService
- update test
- update version
- add changelog
[NAE-2100] Case view export button as NAE feature
- **Add bulk reindexing support**:
    - Introduced the `bulkIndex` method in `IElasticIndexService`, enabling reindexing of all or stale cases and tasks.
    - Created a dedicated `IndexParams` class to encapsulate parameters for the reindexing process (e.g., `indexAll`, `caseBatchSize`, `taskBatchSize`).
    - Optimized the index batching process for cases and tasks by leveraging configurable batch sizes.

- **Remove deprecated methods**:
    - Removed the old `bulkIndex` method from `IElasticIndexService`.
    - Eliminated the obsolete `IBulkService` interface.

- **Update ElasticController**:
    - Changed endpoint, `/reindex/bulk`, for initiating bulk reindexing with configurable parameters.
    - Updated controller logic to leverage the new `bulkIndex` method for improved performance and scalability.

- **Configuration enhancements**:
    - Extended `ElasticsearchProperties` to include `IndexProperties`, allowing batch sizes for cases and tasks to be configured via properties.

- **Code cleanup**:
    - Removed unused imports and annotated services with `@RequiredArgsConstructor`.
    - Streamlined reindexing tasks by integrating advanced filtering and improved logging.

This commit enhances the maintainability and scalability of Elasticsearch reindexing while introducing configurability and improved documentation for reindexing processes.
- updated request param
Added detailed Javadoc comments to improve the clarity of key methods and fields in `ElasticIndexService` and `IndexParams`. This documentation provides insights into parameter usage, default values, and functionalities, facilitating better understanding and maintenance.
Enable and configure JitPack repository for dependency resolution. Update QRGen dependency to version 3.0.1 with updated groupId and artifactId for compatibility.
Updated the reindexing logic to replace BooleanExpression predicates with MongoDB query objects, improving clarity and alignment with MongoDB operations. Adjusted method signatures and internal calls to support the new query-based approach. Renamed `bulkIndex` to `bulkReindex` for consistency with functionality.
Removed unused parameters `now`, `after`, and `indexAll` from the `reindexQueried` method and its invocation. This streamlines the method signature and improves clarity by reducing unnecessary complexity.
tuplle and others added 24 commits March 9, 2026 14:34
…utdown.

- Add `existsById` method and improve task resolution
- Introduced a new `existsById` method in `IUserService` to check user existence.
- Modified `resolveUserRef` in `TaskService` to return a list of resolved tasks instead of void.
- Ensured consistency in validations by replacing `size()` checks with `isEmpty()`.
- Introduced `MigrationProperties` class to define configurable properties for migration, including skip list, cache eviction, and shutdown control.
- Enhanced `MigrationOrderedCommandLineRunner` to respect `MigrationProperties` settings.
- Improved logging for migration operations with additional conditions.
- Upgraded `actions/checkout` from v3 to v6 across workflows for feature improvements and compatibility.
- Updated `actions/setup-java` from v3 to v5 and switched JDK distribution to `temurin`, adding Maven caching where applicable.
- Upgraded MongoDB image to `mongo:6` and Elasticsearch image to `elasticsearch:7.17.28` in workflows.
- Removed deprecated Maven cache setup and unused steps to simplify workflows.
- Added new Maven repositories for central and snapshot artifacts in `pom.xml`.
- Switched JDK distribution to `temurin` and enabled Maven caching in GitHub workflows.
- Upgraded MongoDB service to `mongo:6` and Elasticsearch to `elasticsearch:7.17.28`.
- Updated dependencies including `xml-apis-ext` and various GitHub Actions versions for compatibility.
- Introduced `UserServiceTest` to validate user existence and ID checks.
- Enhanced `ApplicationShutdownProvider` to properly shut down thread pool executors for graceful application termination.
Minor improvements to manage migrations
- Add endpoint to reload tasks of all cases
- add lastModifiedDataSet property to Case and transient property changed to DataField, which is set when value, choices or options on DataField are set
- change changelog and version
- fix duplicity
[NAE-2401] Timestamp of case dataSet change
- fix vulnerability
- fix null pointer
- fix null pointer
# Conflicts:
#	CHANGELOG.md
#	docker-compose.yml
#	pom.xml
#	src/main/java/com/netgrif/application/engine/elastic/service/ElasticCaseService.java
# Conflicts:
#	.github/workflows/master-build.yml
#	.github/workflows/pr-build.yml
#	.github/workflows/release-build.yml
#	CHANGELOG.md
#	docker-compose.yml
#	pom.xml
#	src/main/java/com/netgrif/application/engine/elastic/service/ElasticCaseService.java
#	src/main/java/com/netgrif/application/engine/workflow/domain/menu/MenuItemBody.java
#	src/main/java/com/netgrif/application/engine/workflow/domain/menu/MenuItemConstants.java
#	src/main/resources/petriNets/engine-processes/preference_item.xml
@SamuelPalaj SamuelPalaj self-assigned this May 11, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

Important

Review skipped

Too many files!

This PR contains 257 files, which is 107 over the limit of 150.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5365dda2-aad6-4d27-af1a-cfd9776cd113

📥 Commits

Reviewing files that changed from the base of the PR and between 792f567 and fe4cda6.

📒 Files selected for processing (257)
  • .github/workflows/master-build.yml
  • .github/workflows/pr-build.yml
  • .github/workflows/release-build.yml
  • CHANGELOG.md
  • Dockerfile
  • README.md
  • docker-compose.yml
  • docs/README.md
  • docs/_media/roles/usersRef_net.xml
  • docs/_media/views/Layout-Guide-compacting-example.xml
  • docs/_media/views/Layout-Guide-flow-example.xml
  • docs/_media/views/Layout-Guide-grid-example.xml
  • docs/_media/views/Layout-Guide-legacy-example.xml
  • docs/_navbar.md
  • docs/events/case_event.md
  • docs/events/process_event.md
  • docs/roles/permissions.md
  • docs/roles/shared_roles.md
  • pom.xml
  • src/main/groovy/com/netgrif/application/engine/migration/MigrationOrderedCommandLineRunner.groovy
  • src/main/groovy/com/netgrif/application/engine/startup/RunnerController.groovy
  • src/main/java/com/netgrif/application/engine/auth/service/AbstractUserService.java
  • src/main/java/com/netgrif/application/engine/auth/service/interfaces/IUserService.java
  • src/main/java/com/netgrif/application/engine/configuration/ApplicationShutdownProvider.java
  • src/main/java/com/netgrif/application/engine/configuration/ElasticsearchConfiguration.java
  • src/main/java/com/netgrif/application/engine/configuration/SessionConfiguration.java
  • src/main/java/com/netgrif/application/engine/configuration/properties/ElasticsearchProperties.java
  • src/main/java/com/netgrif/application/engine/configuration/properties/MigrationProperties.java
  • src/main/java/com/netgrif/application/engine/configuration/quartz/QuartzConfiguration.java
  • src/main/java/com/netgrif/application/engine/elastic/domain/CaseField.java
  • src/main/java/com/netgrif/application/engine/elastic/domain/ElasticCase.java
  • src/main/java/com/netgrif/application/engine/elastic/domain/ElasticTask.java
  • src/main/java/com/netgrif/application/engine/elastic/serializer/LocalDateTimeJsonDeserializer.java
  • src/main/java/com/netgrif/application/engine/elastic/serializer/LocalDateTimeJsonSerializer.java
  • src/main/java/com/netgrif/application/engine/elastic/service/ElasticCaseMappingService.java
  • src/main/java/com/netgrif/application/engine/elastic/service/ElasticCaseService.java
  • src/main/java/com/netgrif/application/engine/elastic/service/ElasticIndexService.java
  • src/main/java/com/netgrif/application/engine/elastic/service/ElasticViewPermissionService.java
  • src/main/java/com/netgrif/application/engine/elastic/service/ElasticsearchQuerySanitizer.java
  • src/main/java/com/netgrif/application/engine/elastic/service/ReindexingTask.java
  • src/main/java/com/netgrif/application/engine/elastic/service/interfaces/IElasticCaseService.java
  • src/main/java/com/netgrif/application/engine/elastic/service/interfaces/IElasticIndexService.java
  • src/main/java/com/netgrif/application/engine/elastic/web/ElasticController.java
  • src/main/java/com/netgrif/application/engine/elastic/web/requestbodies/CaseSearchRequest.java
  • src/main/java/com/netgrif/application/engine/elastic/web/requestbodies/ElasticTaskSearchRequest.java
  • src/main/java/com/netgrif/application/engine/elastic/web/requestbodies/IndexParams.java
  • src/main/java/com/netgrif/application/engine/elastic/web/requestbodies/singleaslist/SingleCaseSearchRequestAsList.java
  • src/main/java/com/netgrif/application/engine/elastic/web/requestbodies/singleaslist/SingleElasticTaskSearchRequestAsList.java
  • src/main/java/com/netgrif/application/engine/export/configuration/XlsExportProperties.java
  • src/main/java/com/netgrif/application/engine/export/domain/CellFactory.java
  • src/main/java/com/netgrif/application/engine/export/domain/CellType.java
  • src/main/java/com/netgrif/application/engine/export/domain/ExportedField.java
  • src/main/java/com/netgrif/application/engine/export/service/XlsExportService.java
  • src/main/java/com/netgrif/application/engine/export/service/interfaces/IXlsExportService.java
  • src/main/java/com/netgrif/application/engine/export/utils/XlsExportDateUtils.java
  • src/main/java/com/netgrif/application/engine/export/web/ExportController.java
  • src/main/java/com/netgrif/application/engine/export/web/requestbodies/FilteredCasesRequest.java
  • src/main/java/com/netgrif/application/engine/utils/SingleItemAsListDeserializer.java
  • src/main/java/com/netgrif/application/engine/workflow/domain/Case.java
  • src/main/java/com/netgrif/application/engine/workflow/domain/DataField.java
  • src/main/java/com/netgrif/application/engine/workflow/domain/eventoutcomes/taskoutcomes/FinishTaskEventOutcome.java
  • src/main/java/com/netgrif/application/engine/workflow/domain/repositories/TaskRepository.java
  • src/main/java/com/netgrif/application/engine/workflow/service/DataService.java
  • src/main/java/com/netgrif/application/engine/workflow/service/TaskService.java
  • src/main/java/com/netgrif/application/engine/workflow/service/WorkflowService.java
  • src/main/java/com/netgrif/application/engine/workflow/service/interfaces/IDataService.java
  • src/main/java/com/netgrif/application/engine/workflow/service/interfaces/ITaskService.java
  • src/main/java/com/netgrif/application/engine/workflow/utils/CaseSearchRequestSingleItemAsListDeserializer.java
  • src/main/java/com/netgrif/application/engine/workflow/utils/TaskSearchRequestSingleItemAsListDeserializer.java
  • src/main/java/com/netgrif/application/engine/workflow/web/AbstractTaskController.java
  • src/main/java/com/netgrif/application/engine/workflow/web/PublicTaskController.java
  • src/main/java/com/netgrif/application/engine/workflow/web/TaskController.java
  • src/main/java/com/netgrif/application/engine/workflow/web/WorkflowController.java
  • src/main/java/com/netgrif/application/engine/workflow/web/requestbodies/singleaslist/SingleTaskSearchRequestAsList.java
  • src/main/java/com/netgrif/application/engine/workflow/web/responsebodies/eventoutcomes/LocalisedFinishTaskEventOutcome.java
  • src/main/resources/application-dev.properties
  • src/main/resources/application.properties
  • src/main/resources/petriNets/all_data.xml
  • src/main/resources/petriNets/datamap.xml
  • src/main/resources/petriNets/engine-processes/dashboard.xml
  • src/main/resources/petriNets/engine-processes/dashboard_tile.xml
  • src/main/resources/petriNets/engine-processes/export_filters.xml
  • src/main/resources/petriNets/engine-processes/filter.xml
  • src/main/resources/petriNets/engine-processes/impersonation_config.xml
  • src/main/resources/petriNets/engine-processes/impersonation_users_select.xml
  • src/main/resources/petriNets/engine-processes/import_filters.xml
  • src/main/resources/petriNets/engine-processes/menu/tabbed_case_view_configuration.xml
  • src/main/resources/petriNets/engine-processes/org_group.xml
  • src/main/resources/petriNets/engine-processes/preference_filter_item.xml
  • src/main/resources/petriNets/insurance_portal_demo.xml
  • src/main/resources/petriNets/insurance_role_test.xml
  • src/main/resources/petriNets/leukemia.xml
  • src/main/resources/petriNets/leukemia_en.xml
  • src/main/resources/petriNets/mortgage/address.xml
  • src/main/resources/petriNets/mortgage/financial_data.xml
  • src/main/resources/petriNets/mortgage/financial_data_doc.xml
  • src/main/resources/petriNets/mortgage/financial_data_func.xml
  • src/main/resources/petriNets/mortgage/mortgage.xml
  • src/main/resources/petriNets/mortgage/mortgage_modeler.xml
  • src/main/resources/petriNets/mortgage/personal_information.xml
  • src/main/resources/petriNets/petriflow_schema.xsd
  • src/main/resources/petriNets/posudky.xml
  • src/main/resources/petriNets/taskRef-propagation/child.xml
  • src/main/resources/petriNets/taskRef-propagation/parent.xml
  • src/main/resources/petriNets/test_model_immediate_data.xml
  • src/main/resources/petriNets/wizard.xml
  • src/test/groovy/com/netgrif/application/engine/elastic/DataSearchRequestTest.groovy
  • src/test/groovy/com/netgrif/application/engine/export/service/XlsExportServiceTest.java
  • src/test/groovy/com/netgrif/application/engine/workflow/TaskControllerTest.groovy
  • src/test/java/com/netgrif/application/engine/auth/service/UserServiceTest.java
  • src/test/java/com/netgrif/application/engine/elastic/ElasticsearchQuerySanitizerTest.java
  • src/test/resources/actionref_test.xml
  • src/test/resources/all_data.xml
  • src/test/resources/all_data_pdf.xml
  • src/test/resources/arc_order_test.xml
  • src/test/resources/arc_reference_invalid_test.xml
  • src/test/resources/arc_reference_test.xml
  • src/test/resources/assignRoleMainNet_test_.xml
  • src/test/resources/assignRoleSecondaryNet_test.xml
  • src/test/resources/assign_cancel_finish_with_Case_test.xml
  • src/test/resources/autotrigger_taskref.xml
  • src/test/resources/case_choices_test.xml
  • src/test/resources/case_search_test.xml
  • src/test/resources/caseref_test.xml
  • src/test/resources/change_allowed_nets_action_test.xml
  • src/test/resources/change_caseref_value_action_test.xml
  • src/test/resources/constructor_destructor.xml
  • src/test/resources/create_case_locale.xml
  • src/test/resources/currency_test.xml
  • src/test/resources/data_button_test.xml
  • src/test/resources/data_map.xml
  • src/test/resources/data_map_2.xml
  • src/test/resources/data_service_referenced.xml
  • src/test/resources/data_service_taskref.xml
  • src/test/resources/data_test.xml
  • src/test/resources/data_text_validation.xml
  • src/test/resources/datagroup_test_layout.xml
  • src/test/resources/enum_list.xml
  • src/test/resources/enumeration_multichoice_options.xml
  • src/test/resources/event_test.xml
  • src/test/resources/field_view.xml
  • src/test/resources/file_test.xml
  • src/test/resources/file_test_net.xml
  • src/test/resources/flow.xml
  • src/test/resources/initial_behavior.xml
  • src/test/resources/ipc_bulk.xml
  • src/test/resources/ipc_createCase.xml
  • src/test/resources/ipc_data.xml
  • src/test/resources/ipc_group.xml
  • src/test/resources/ipc_set_data.xml
  • src/test/resources/ipc_task_search.xml
  • src/test/resources/ipc_transition_role.xml
  • src/test/resources/ipc_where.xml
  • src/test/resources/mapping_test.xml
  • src/test/resources/nae-1272_datagroup_divider_improvement.xml
  • src/test/resources/net_clone.xml
  • src/test/resources/net_import_1.xml
  • src/test/resources/net_import_2.xml
  • src/test/resources/org_group.xml
  • src/test/resources/pdf_run_action.xml
  • src/test/resources/pdf_test_1.xml
  • src/test/resources/pdf_test_2.xml
  • src/test/resources/pdf_test_3.xml
  • src/test/resources/petriNets/NAE_1305_Loading_na_set_data_pre_button.xml
  • src/test/resources/petriNets/NAE_1382_first_trans_auto.xml
  • src/test/resources/petriNets/NAE_1382_first_trans_auto_2.xml
  • src/test/resources/petriNets/action_delegate_concurrency_test.xml
  • src/test/resources/petriNets/all_data_refs.xml
  • src/test/resources/petriNets/change_field_value_init.xml
  • src/test/resources/petriNets/changed_fields_allowed_nets.xml
  • src/test/resources/petriNets/data_actions_test.xml
  • src/test/resources/petriNets/dynamic_case_name_test.xml
  • src/test/resources/petriNets/dynamic_choices.xml
  • src/test/resources/petriNets/dynamic_init.xml
  • src/test/resources/petriNets/dynamic_validations.xml
  • src/test/resources/petriNets/dynamic_validations_performance_test.xml
  • src/test/resources/petriNets/dynamic_validations_performance_test_comparison.xml
  • src/test/resources/petriNets/function_overloading.xml
  • src/test/resources/petriNets/function_overloading_fail.xml
  • src/test/resources/petriNets/function_overloading_fail_v2.xml
  • src/test/resources/petriNets/function_overloading_v2.xml
  • src/test/resources/petriNets/function_res.xml
  • src/test/resources/petriNets/function_res_v2.xml
  • src/test/resources/petriNets/function_test.xml
  • src/test/resources/petriNets/function_test_v2.xml
  • src/test/resources/petriNets/groovy_shell_test.xml
  • src/test/resources/petriNets/impersonation_test.xml
  • src/test/resources/petriNets/importer_upsert.xml
  • src/test/resources/petriNets/mortgage_net.xml
  • src/test/resources/petriNets/nae_1276_Init_value_as_choice.xml
  • src/test/resources/petriNets/role_assign_remove_test.xml
  • src/test/resources/petriNets/role_test.xml
  • src/test/resources/petriNets/task_controller_set_data.xml
  • src/test/resources/petriNets/validation/valid_boolean.xml
  • src/test/resources/petriNets/validation/valid_date.xml
  • src/test/resources/petriNets/validation/valid_number.xml
  • src/test/resources/petriNets/validation/valid_regex.xml
  • src/test/resources/petriNets/validation/valid_text.xml
  • src/test/resources/predefinedPermissions/role_permissions_anonymous_role_combined.xml
  • src/test/resources/predefinedPermissions/role_permissions_anonymous_role_custom.xml
  • src/test/resources/predefinedPermissions/role_permissions_anonymous_role_defined.xml
  • src/test/resources/predefinedPermissions/role_permissions_anonymous_role_disabled.xml
  • src/test/resources/predefinedPermissions/role_permissions_anonymous_role_missing.xml
  • src/test/resources/predefinedPermissions/role_permissions_anonymous_role_negative.xml
  • src/test/resources/predefinedPermissions/role_permissions_anonymous_role_reserved.xml
  • src/test/resources/predefinedPermissions/role_permissions_anonymous_role_shadowed.xml
  • src/test/resources/predefinedPermissions/role_permissions_anonymous_role_shadowed_userref.xml
  • src/test/resources/predefinedPermissions/role_permissions_anonymous_role_shadowed_usersref.xml
  • src/test/resources/predefinedPermissions/role_permissions_combined_roles_defined.xml
  • src/test/resources/predefinedPermissions/role_permissions_combined_roles_undefined.xml
  • src/test/resources/predefinedPermissions/role_permissions_default_role_combined.xml
  • src/test/resources/predefinedPermissions/role_permissions_default_role_custom.xml
  • src/test/resources/predefinedPermissions/role_permissions_default_role_defined.xml
  • src/test/resources/predefinedPermissions/role_permissions_default_role_disabled.xml
  • src/test/resources/predefinedPermissions/role_permissions_default_role_missing.xml
  • src/test/resources/predefinedPermissions/role_permissions_default_role_negative.xml
  • src/test/resources/predefinedPermissions/role_permissions_default_role_reserved.xml
  • src/test/resources/predefinedPermissions/role_permissions_default_role_shadowed.xml
  • src/test/resources/predefinedPermissions/role_permissions_default_role_shadowed_userref.xml
  • src/test/resources/predefinedPermissions/role_permissions_default_role_shadowed_usersref.xml
  • src/test/resources/priloha.xml
  • src/test/resources/process_delete_test.xml
  • src/test/resources/process_search_test.xml
  • src/test/resources/remoteFileField.xml
  • src/test/resources/remoteFileListField.xml
  • src/test/resources/removeRole_test.xml
  • src/test/resources/role_cancel_test.xml
  • src/test/resources/rolref_view.xml
  • src/test/resources/rule_engine_test.xml
  • src/test/resources/simple_taskref.xml
  • src/test/resources/taskRefLayoutTest.xml
  • src/test/resources/taskRefLayoutTest2.xml
  • src/test/resources/taskRefLayoutTest3.xml
  • src/test/resources/taskRefLayoutTest4.xml
  • src/test/resources/taskRef_propagation_test_child.xml
  • src/test/resources/taskRef_propagation_test_parent.xml
  • src/test/resources/task_authentication_service_test.xml
  • src/test/resources/task_authorization_service_test.xml
  • src/test/resources/task_authorization_service_test_with_userRefs.xml
  • src/test/resources/task_cancel_net.xml
  • src/test/resources/task_events.xml
  • src/test/resources/task_reindex_test.xml
  • src/test/resources/taskref_demo.xml
  • src/test/resources/taskref_init.xml
  • src/test/resources/test_autocomplete_dynamic.xml
  • src/test/resources/test_icon_enum.xml
  • src/test/resources/test_inter_data_actions_dynamic.xml
  • src/test/resources/test_inter_data_actions_static.xml
  • src/test/resources/test_setData.xml
  • src/test/resources/this_kw_test.xml
  • src/test/resources/user_list.xml
  • src/test/resources/userrefs_test.xml
  • src/test/resources/variable_arc_test.xml
  • src/test/resources/view_permission_test.xml
  • src/test/resources/view_permission_with_userRefs_test.xml
  • src/test/resources/workflow_authorization_service_test.xml
  • src/test/resources/workflow_authorization_service_test_with_userRefs.xml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@mazarijuraj mazarijuraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged, 💩 will be cleaned up during Core merge

// log.warn(String.format("DateFields should have LocalDate values! DateField (%s) with Date value found! Value will be converted for indexation.", netField.getImportId()));
LocalDateTime transformed = this.transformDateValueField(dateField);
return formatDateField(LocalDateTime.of(transformed.toLocalDate(), LocalTime.NOON));
return formatDateField(LocalDateTime.of(transformed.toLocalDate(), LocalTime.MIDNIGHT));
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed?

return null;
else
return query;
return resultAlwaysEmpty ? null : query;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💩

processQuery.setGroup(request.group);
List<PetriNetReference> groupProcesses = this.petriNetService.search(processQuery, user, new FullPageRequest(), locale).getContent();
if (groupProcesses.size() == 0)
if (groupProcesses.isEmpty()) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check should be done in a separate function and first in buildSingleQuery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants