test: try 20-next #292
Draft
test: try 20-next #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
✅ Deploy Preview for plugin-angular-universal-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pieh
commented
Apr 11, 2025
| import { appConfig } from './app.config' | ||
| import { serverRoutes } from './app.routes.server' | ||
|
|
||
| const serverConfig: ApplicationConfig = { | ||
| providers: [provideServerRendering(), provideServerRoutesConfig(serverRoutes)], | ||
| providers: [provideServerRendering(withRoutes(serverRoutes))], |
There was a problem hiding this comment.
This had to be migrated manually (checked how newly scaffolded project with npx @angular/cli@next new sets things up) as ng update @angular/cli @angular/core --next didn't cover it (initially it resulted in trying to import no longer existing provideServerRoutesConfig function)
|
Note - test on Node 18 fail because it's unsupported with Angular 20: Test setup would need adjustment to skip tests using Angular 20 when on not supported Node version to continue testing previous Angular major versions (or maybe drop testing this node version as it's no longer maintained anyway) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just optimistic change trying out:
And ensuring min node supported version in Angular 20 is used to build the app