fix(ci): mark introspect.py executable (ruff EXE001) - #79
Merged
Conversation
The main Lint run reported 'EXE001 Shebang is present but file is not executable' for skills/php-modernization/scripts/introspect.py: git had it at mode 100644 while it carries a '#!/usr/bin/env python3' shebang and PEP 723 script metadata. Its sibling scripts (modernize_loop.py, verify_php_project.py) are already 100755 and pass, so the fix is to record the same executable mode here. Note: the CI's ruff (unpinned uvx ruff, see skill-repo-skill#183) reports EXE001 while an older local ruff does not, so this could not be reproduced locally; the change matches the passing sibling files exactly (shebang + executable). Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #78. After the ruff fixes there, the main Lint surfaced the next newer-ruff finding:
git had
introspect.pyat mode 100644 despite its#!/usr/bin/env python3shebang + PEP 723# /// scriptmetadata. Its siblingsmodernize_loop.pyandverify_php_project.pyare already 100755 and pass, so this records the same executable mode.The CI's unpinned
uvx ruffreports EXE001 while an older local ruff does not (skill-repo-skill#183), so it couldn't be reproduced locally — the change matches the passing sibling files exactly.