added RejectedRequestException #173
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
referenced
this pull request
Jan 26, 2017
…stead BadRequestException when incompatible type is object
dg
force-pushed
the
v2.4
branch
2 times, most recently
from
30b8609 to
97edb43
Compare
dg
force-pushed
the
reject
branch
2 times, most recently
from
dedb5e5 to
4e07a2d
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
88ef0bd to
b7df270
Compare
dg
force-pushed
the
master
branch
10 times, most recently
from
8dabc1a to
2e29386
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
bf86204 to
c91f90a
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
57bd587 to
e908315
Compare
dg
force-pushed
the
master
branch
8 times, most recently
from
c5ecbda to
ecb200c
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
3463b9a to
ee24f8e
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
ddf16b5 to
87e4597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case that framework rejects request, it throws
RejectedRequestExceptioninstead ofBadRequestExceptionorBadSignalException. TheBadSignalExceptionshould be deprecated in future.The main reason is to reach finer granularity for BadRequestException exception.
The naming should be discussed. Is better RejectRequestException or RejectedRequestException? What about constants in RejectedRequestException?
ping @JanTvrdik @matej21