Skip to content

IControl::setValue() ⇒ setCurrentValues() #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

IControl::setValue() ⇒ setCurrentValues() #122

wants to merge 1 commit into from

Conversation

@dg
Copy link
Member

@dg dg commented Jun 30, 2016

to solve #114

@dg dg force-pushed the master branch 2 times, most recently from 802f3d4 to ed7ecd7 Compare June 30, 2016 18:18
@dg dg force-pushed the master branch 3 times, most recently from 27d3e69 to 57295d1 Compare July 9, 2016 12:02
@JanTvrdik
Copy link
Contributor

JanTvrdik commented Sep 22, 2016 •
edited
Loading

Looks like pointless BC break to me.

@dg
Copy link
Member Author

dg commented Sep 26, 2016

Point #114

@mrtnzlml
Copy link

I never did not fully understand (or remember) difference between setValue and setDefaultValue and I am using it wrong for sure (at least I think). I am totally supporting some kind of change because there would be a lot of similar developers with the same problem as I have... :)

@JanTvrdik
Copy link
Contributor

I'm aware of the point, but I think that the number of people who accidentally use setValue is very low.

@dg dg force-pushed the master branch 2 times, most recently from 5f19501 to 105a1af Compare January 4, 2017 14:16
@dg dg force-pushed the master branch 14 times, most recently from a6ec22a to c2c4dc3 Compare January 30, 2017 00:54
@dg dg force-pushed the master branch 2 times, most recently from 49c38f3 to c6f98c1 Compare April 1, 2024 01:05
@dg dg force-pushed the master branch 4 times, most recently from 337f707 to 2146e59 Compare May 2, 2024 10:56
@dg dg force-pushed the master branch 6 times, most recently from 94f43f0 to fe374c5 Compare May 12, 2024 13:07
@dg dg force-pushed the master branch 7 times, most recently from cb844f0 to 1d8a434 Compare August 8, 2024 14:36
@dg dg force-pushed the master branch 2 times, most recently from 479185b to 8da5796 Compare October 22, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@dg @JanTvrdik @mrtnzlml @f3l1x @hrach