-
-
Notifications
You must be signed in to change notification settings - Fork 151
Arrays::updateDiff() #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
milo
wants to merge
2
commits into
nette:master
Choose a base branch
from
milo:pull-array-diff
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Arrays::updateDiff() #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
So it's like |
Member
Author
|
Yes. Behaviour probably same as: return array_udiff_assoc($to, $from, function ($a, $b) {
return $a === $b ? 0 : ($a > $b ? 1 : -1); # spaceship cannot be used because null <=> false === 0
});I write probably, because I'm not sure why yes/no comparator can return -1/0/1 and how result depends on it. |
740520b to
2bc2f58
Compare
eb3a987 to
adead06
Compare
c5fe864 to
f06376c
Compare
1d3a574 to
f857e45
Compare
2aa5187 to
9f1c637
Compare
cd9170e to
2b48b24
Compare
6f1918e to
be53471
Compare
ba103e3 to
ce70865
Compare
9aff0b8 to
e67c406
Compare
a702672 to
5ab770f
Compare
99fbd2d to
8ee89b1
Compare
1765d9d to
17932ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed
Arrays::updateDiff()compares two associative arrays and returns such items from later one, which does not exist or differs from first one. By other words - which items have to be updated in first array, to be the same as second array.As far as I know, there is no PHP function for that (playground). For examle:
There are posible things to debate:
callable $comparator = null