Skip to content

Fixes exclude to work with lists #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 17, 2025
Merged

Fixes exclude to work with lists #123

merged 6 commits into from
Apr 17, 2025

Conversation

joewesch
Copy link
Contributor

@joewesch joewesch commented Apr 9, 2025

Fixes: #122

@joewesch joewesch force-pushed the u/joewesch-122-exclude branch from 4999b95 to 5b1b638 Compare April 17, 2025 14:19
pszulczewski
pszulczewski approved these changes Apr 17, 2025
View reviewed changes
Copy link
Collaborator

@pszulczewski pszulczewski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it enhances exclude to work with more nested data format in this case list of dicts.

@pszulczewski pszulczewski merged commit e1da41e into networktocode:develop Apr 17, 2025
14 checks passed
@joewesch joewesch deleted the u/joewesch-122-exclude branch April 17, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pszulczewski pszulczewski pszulczewski approved these changes

@chadell chadell Awaiting requested review from chadell chadell is a code owner

@lvrfrc87 lvrfrc87 Awaiting requested review from lvrfrc87 lvrfrc87 is a code owner

@scetron scetron Awaiting requested review from scetron scetron is a code owner

@jeffkala jeffkala Awaiting requested review from jeffkala jeffkala is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exclude not working with data lists for extract_data_from_json
2 participants
@joewesch @pszulczewski